fix #27642, static members should now work

pkg/dev_compiler/lib/src/compiler/code_generator.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:collection' show HashMap, HashSet;
 import 'dart:math' show min, max;
 
 import 'package:analyzer/analyzer.dart' hide ConstantEvaluator;
 import 'package:analyzer/dart/ast/ast.dart';
@@ skipping 4641 matching lines @@
     // TODO(jmesserly): handle explicitly passed type args.
     if (type == null) return null;
     return _emitFunctionTypeArguments(type, instantiated);
   }
 
   JS.LiteralString _emitDynamicOperationName(String name) =>
       js.string(options.replCompile ? '${name}Repl' : name);
 
   JS.Expression _emitAccessInternal(Expression target, Element member,
       String memberName, List<JS.Expression> typeArgs) {
-    bool isStatic = member is ClassMemberElement && member.isStatic;
+    // TODO(jmesserly): we don't use member.isStatic because it doesn't seem to
+    // work, see https://github.com/dart-lang/sdk/issues/27642 for context.
+    bool isStatic = target is SimpleIdentifier &&
+        target.staticElement is TypeDefiningElement;

[vsm, 2016/10/21 02:07:16]

Hmm, do we need target is SimpleIdentifier?

Might have:

foo.A.x;

where foo is a library prefix.

[Jennifer Messerly, 2016/10/21 17:48:07]

yes, we need something. You can't get a staticElement from an Expression
yes, I believe this is handled by _emitAccess and is why tests passed, but I
will double check. If not, we can also add a "target is PrefixedIdentifier"
branch.

     var name = _emitMemberName(memberName,
         type: getStaticType(target), isStatic: isStatic);
     if (isDynamicInvoke(target)) {
       if (_inWhitelistCode(target)) {
         var vars = <JS.MetaLetVariable, JS.Expression>{};
         var l = _visit(_bindValue(vars, 'l', target));
         return new JS.MetaLet(vars, [
           js.call('(#[dart._extensionType]) ? #[dartx[#]] : #.#',
               [l, l, name, l, name])
         ]);
@@ skipping 846 matching lines @@
 }
 
 bool isLibraryPrefix(Expression node) =>
     node is SimpleIdentifier && node.staticElement is PrefixElement;
 
 LibraryElement _getLibrary(AnalysisContext c, String uri) =>
     c.computeLibraryElement(c.sourceFactory.forUri(uri));
 
 bool _isDartRuntime(LibraryElement l) =>
     l.isInSdk && l.source.uri.toString() == 'dart:_runtime';