Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2439023002: Fix static modifier for synthetic fields coming from summaries. (Closed)

Created:
4 years, 2 months ago by Paul Berry
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org, Jennifer Messerly
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Paul Berry
4 years, 2 months ago (2016-10-21 11:07:21 UTC) #2
Paul Berry
4 years, 2 months ago (2016-10-21 11:09:09 UTC) #3
scheglov
LGTM
4 years, 2 months ago (2016-10-21 17:19:59 UTC) #4
Jennifer Messerly
LGTM! Thank you! I'll test this out on the DDC side
4 years, 2 months ago (2016-10-21 17:52:35 UTC) #6
Jennifer Messerly
I can confirm this fixes things :)
4 years, 2 months ago (2016-10-21 17:55:17 UTC) #7
Paul Berry
4 years, 2 months ago (2016-10-21 18:09:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f1aee7cf682909ca53067cd6ef581836864e1db7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698