MacViews: Build more unit_tests.

MacViews: Build more unit_tests.

I've enabled the tests that compile and link with mac_views_browser enabled.

BUG=657883
Committed: https://crrev.com/ac6e6ef42555b47257d2e7bc9b7672794c011899
Cr-Commit-Position: refs/heads/master@{#426776}

[themblsha, 2016-10-20 17:02:25]

Description was changed from

==========
MacViews: Build more unit_tests.

I've enabled the tests that compile and link with mac_views_browser enabled.

BUG=657883
==========

to

==========
MacViews: Build more unit_tests.

I've enabled the tests that compile and link with mac_views_browser enabled.

BUG=657883
==========

[themblsha, 2016-10-20 17:02:26]

mblsha@yandex-team.ru changed reviewers:
+ sky@chromium.org, tapted@chromium.org

[sky, 2016-10-20 19:54:22]

Assuming they all actually work too, LGTM

[tapted, 2016-10-21 02:11:39]

On 2016/10/20 19:54:22, sky wrote:
> Assuming they all actually work too, LGTM

There are some pre-existing failures (#hides). I think this is OK so we can
start monitoring more compile regressions. So lgtm. It does look like there will
be new failures in ChooserDialogViewTest.* and
ToolbarActionsBarBubbleViewsTest.*. I've updated http://crbug.com/657883 with
notes about this so we can track fixes there.

As part of test setup, ChooserDialogViewTest does
    dialog_ =
views::DialogDelegate::CreateDialogWidget(chooser_dialog_view.release(),
GetContext(), nullptr);

That `nullptr` is passing a null parent window, but
ChooserDialogView::GetModalType() says it is `ui::MODAL_TYPE_CHILD`, so a DCHECK
is hit on Mac.

ToolbarActionsBarBubbleViewsTest has some close/lifetime problems.

There are also some current failures (not many -
http://go/macviewsbuilder/builds/16792/steps/unit_tests [internal link - sorry]
- ConfirmBubbleViewsTest. and TranslateManagerRenderViewHostTest). We should
investigate all these.


Note we want to ensure the ones we enable make sense for where mac_views_browser
is headed. E.g. `status_tray_win_unittest` isn't needed, but it will get
filtered out by the platform regex. stacked_tab_strip_layout_unittest.cc is I
think for touch interfaces so we might not want that on Mac for the foreseeable
future, but stacked_tab_strip_layout.cc should be removed from the build at the
same time -- I filed http://crbug.com/658107 for that.

[tapted, 2016-10-21 04:48:50]

oops - didn't publish drafts - lgtm after adding that todo

https://codereview.chromium.org/2440743002/diff/1/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2440743002/diff/1/chrome/test/BUILD.gn#newcod...
chrome/test/BUILD.gn:4738: sources += [
Can you a TODO here ~"Get these compiling on Mac - see http://crbug.com/657883."

https://codereview.chromium.org/2440743002/diff/1/chrome/test/BUILD.gn#newcod...
chrome/test/BUILD.gn:4739:
"../browser/ui/views/apps/shaped_app_window_targeter_unittest.cc",
(I think this is the only one we really don't care about on Mac)

[themblsha, 2016-10-21 11:42:00]

The CQ bit was checked by mblsha@yandex-team.ru

[themblsha, 2016-10-21 11:42:00]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2440743002/#ps20001
(title: "Add comment to motivate fixing the tests on Mac.")

[commit-bot: I haz the power, 2016-10-21 11:42:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[themblsha, 2016-10-21 11:42:19]

https://codereview.chromium.org/2440743002/diff/1/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2440743002/diff/1/chrome/test/BUILD.gn#newcod...
chrome/test/BUILD.gn:4738: sources += [
On 2016/10/21 04:48:50, tapted wrote:
> Can you a TODO here ~"Get these compiling on Mac - see
http://crbug.com/657883.%22

Done.

[commit-bot: I haz the power, 2016-10-21 12:40:55]

Description was changed from

==========
MacViews: Build more unit_tests.

I've enabled the tests that compile and link with mac_views_browser enabled.

BUG=657883
==========

to

==========
MacViews: Build more unit_tests.

I've enabled the tests that compile and link with mac_views_browser enabled.

BUG=657883
==========

[commit-bot: I haz the power, 2016-10-21 12:40:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:28:59]

Description was changed from

==========
MacViews: Build more unit_tests.

I've enabled the tests that compile and link with mac_views_browser enabled.

BUG=657883
==========

to

==========
MacViews: Build more unit_tests.

I've enabled the tests that compile and link with mac_views_browser enabled.

BUG=657883

Committed: https://crrev.com/ac6e6ef42555b47257d2e7bc9b7672794c011899
Cr-Commit-Position: refs/heads/master@{#426776}
==========

[commit-bot: I haz the power, 2016-10-21 13:29:00]

Patchset 2 (id:??) landed as
https://crrev.com/ac6e6ef42555b47257d2e7bc9b7672794c011899
Cr-Commit-Position: refs/heads/master@{#426776}