Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5276)

Unified Diff: chrome/test/BUILD.gn

Issue 2440743002: MacViews: Build more unit_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment to motivate fixing the tests on Mac. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index f2cd2283a0aff63806efe396aed5ccf624e42c9b..4ad072dececcf4f2989994e7d818e15484eff40c 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -4698,10 +4698,9 @@ test("unit_tests") {
"../browser/ui/views/sync/one_click_signin_dialog_view_unittest.cc",
]
}
- if (!is_mac) {
+ if (!is_mac || mac_views_browser) {
sources += [
"../browser/ui/views/accelerator_table_unittest.cc",
- "../browser/ui/views/apps/shaped_app_window_targeter_unittest.cc",
"../browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc",
"../browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc",
"../browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc",
@@ -4709,12 +4708,8 @@ test("unit_tests") {
"../browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc",
"../browser/ui/views/chooser_content_view_unittest.cc",
"../browser/ui/views/confirm_bubble_views_unittest.cc",
- "../browser/ui/views/crypto_module_password_dialog_view_unittest.cc",
- "../browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc",
- "../browser/ui/views/desktop_media_picker_views_deprecated_unittest.cc",
"../browser/ui/views/extensions/chooser_dialog_view_unittest.cc",
"../browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc",
- "../browser/ui/views/first_run_bubble_unittest.cc",
"../browser/ui/views/frame/browser_non_client_frame_view_unittest.cc",
"../browser/ui/views/frame/browser_view_layout_unittest.cc",
"../browser/ui/views/frame/browser_view_unittest.cc",
@@ -4739,6 +4734,17 @@ test("unit_tests") {
"../browser/ui/views/translate/translate_bubble_view_unittest.cc",
]
}
+ if (use_aura) {
+ sources += [
+ "../browser/ui/views/apps/shaped_app_window_targeter_unittest.cc",
+
+ # Get these compiling on Mac - see http://crbug.com/657883.
+ "../browser/ui/views/crypto_module_password_dialog_view_unittest.cc",
+ "../browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc",
+ "../browser/ui/views/desktop_media_picker_views_deprecated_unittest.cc",
+ "../browser/ui/views/first_run_bubble_unittest.cc",
+ ]
+ }
}
if (!is_android && use_nss_certs) {
sources += [ "../common/net/x509_certificate_model_unittest.cc" ]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698