Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2414913004: Cleanup of FullscreenManager. (Closed)

Created:
4 years, 2 months ago by Ted C
Modified:
4 years, 2 months ago
Reviewers:
gone
CC:
chromium-reviews, dominickn+watch_chromium.org, lizeb+watch-custom-tabs_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup of FullscreenManager. Removes dependency on TabModelSelector and relies on setting a tab directly. BUG= Committed: https://crrev.com/64dc72e368d05360c9c782e88ace40223672f544 Cr-Commit-Position: refs/heads/master@{#425157}

Patch Set 1 #

Patch Set 2 : tab null check #

Total comments: 2

Patch Set 3 : Add comment #

Messages

Total messages: 10 (4 generated)
Ted C
PTAL
4 years, 2 months ago (2016-10-13 00:34:29 UTC) #2
gone
lgtm https://chromiumcodereview.appspot.com/2414913004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java File chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java (right): https://chromiumcodereview.appspot.com/2414913004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java#newcode129 chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java:129: if (mTab != null) mTab.setFullscreenManager(null); wut. Can you ...
4 years, 2 months ago (2016-10-13 18:44:15 UTC) #3
Ted C
https://codereview.chromium.org/2414913004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java File chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java (right): https://codereview.chromium.org/2414913004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java#newcode129 chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java:129: if (mTab != null) mTab.setFullscreenManager(null); On 2016/10/13 18:44:15, dfalcantara ...
4 years, 2 months ago (2016-10-13 20:21:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414913004/40001
4 years, 2 months ago (2016-10-13 20:22:19 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-13 21:10:38 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 21:14:08 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/64dc72e368d05360c9c782e88ace40223672f544
Cr-Commit-Position: refs/heads/master@{#425157}

Powered by Google App Engine
This is Rietveld 408576698