Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2440303002: Remove usage of FOR_EACH_OBSERVER macro in components/ (Closed)

Created:
4 years, 1 month ago by Eric Willigers
Modified:
4 years, 1 month ago
Reviewers:
sdefresne
CC:
chromium-reviews, msramek+watch_chromium.org, zea+watch_chromium.org, Peter Beverloo, johnme+watch_chromium.org, cbentzel+watch_chromium.org, raymes+watch_chromium.org, asvitkine+watch_chromium.org, markusheintz_, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in components/ Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/a22488d46eda64d30a93a3d75c1fb5e41b486a1d Cr-Commit-Position: refs/heads/master@{#427212}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove superfluous return #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -61 lines) Patch
M components/content_settings/core/browser/content_settings_observable_provider.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M components/content_settings/core/browser/host_content_settings_map.cc View 1 1 chunk +4 lines, -6 lines 0 comments Download
M components/cronet/android/cronet_in_memory_pref_store.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/data_usage/core/data_use_aggregator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/dom_distiller/core/distilled_page_prefs.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M components/dom_distiller/core/dom_distiller_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/exo/surface.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/exo/wm_helper.cc View 1 chunk +14 lines, -14 lines 0 comments Download
M components/favicon/core/favicon_driver.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M components/infobars/core/infobar_manager.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M components/metrics/leak_detector/leak_detector.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/metrics/metrics_service.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Eric Willigers
4 years, 1 month ago (2016-10-23 23:32:19 UTC) #4
sdefresne
lgtm thank you for the cleanup https://codereview.chromium.org/2440303002/diff/1/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc File components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc (right): https://codereview.chromium.org/2440303002/diff/1/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc#newcode315 components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc:315: return; nit: remove
4 years, 1 month ago (2016-10-24 20:31:12 UTC) #7
Eric Willigers
https://codereview.chromium.org/2440303002/diff/1/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc File components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc (right): https://codereview.chromium.org/2440303002/diff/1/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc#newcode315 components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc:315: return; On 2016/10/24 20:31:12, sdefresne wrote: > nit: remove ...
4 years, 1 month ago (2016-10-24 22:55:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440303002/20001
4 years, 1 month ago (2016-10-24 22:57:23 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/179659)
4 years, 1 month ago (2016-10-24 23:11:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440303002/20001
4 years, 1 month ago (2016-10-25 01:05:16 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-25 01:21:19 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 01:24:05 UTC) #20
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a22488d46eda64d30a93a3d75c1fb5e41b486a1d
Cr-Commit-Position: refs/heads/master@{#427212}

Powered by Google App Engine
This is Rietveld 408576698