Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc

Issue 2440303002: Remove usage of FOR_EACH_OBSERVER macro in components/ (Closed)
Patch Set: remove superfluous return Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/core/favicon_driver.cc ('k') | components/gcm_driver/gcm_driver_desktop.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc
diff --git a/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc b/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc
index c6f2b3d7635cb164d5071fa6abc250a703b88bdd..74638b0c65d90be72e5b0e0b664cd2588d4d803b 100644
--- a/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc
+++ b/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc
@@ -229,7 +229,8 @@ void FilesystemJsonPrefStore::ReportValueChanged(const std::string& key,
if (pref_filter_)
pref_filter_->FilterUpdate(key);
- FOR_EACH_OBSERVER(PrefStore::Observer, observers_, OnPrefValueChanged(key));
+ for (PrefStore::Observer& observer : observers_)
+ observer.OnPrefValueChanged(key);
ScheduleWrite(flags);
}
@@ -308,10 +309,8 @@ void FilesystemJsonPrefStore::FinalizeFileRead(
if (error_delegate_ && read_error_ != PREF_READ_ERROR_NONE)
error_delegate_->OnError(read_error_);
- FOR_EACH_OBSERVER(PrefStore::Observer, observers_,
- OnInitializationCompleted(true));
-
- return;
+ for (PrefStore::Observer& observer : observers_)
+ observer.OnInitializationCompleted(true);
}
void FilesystemJsonPrefStore::ScheduleWrite(uint32_t flags) {
« no previous file with comments | « components/favicon/core/favicon_driver.cc ('k') | components/gcm_driver/gcm_driver_desktop.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698