components/content_settings/core/browser/host_content_settings_map.cc - Issue 2440303002: Remove usage of FOR_EACH_OBSERVER macro in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/host_content_settings_map.cc

Issue 2440303002: Remove usage of FOR_EACH_OBSERVER macro in components/ (Closed)

Patch Set: remove superfluous return Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/content_settings/core/browser/content_settings_observable_provider.cc ('k') | components/cronet/android/cronet_in_memory_pref_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/host_content_settings_map.cc

diff --git a/components/content_settings/core/browser/host_content_settings_map.cc b/components/content_settings/core/browser/host_content_settings_map.cc

index 3c3fd883c08914ff7cbe5f7ca6dbd973049e23de..4c1a473c1292f53bc92cf28f45562567837ec6a2 100644

--- a/components/content_settings/core/browser/host_content_settings_map.cc

+++ b/components/content_settings/core/browser/host_content_settings_map.cc

@@ -788,12 +788,10 @@ void HostContentSettingsMap::OnContentSettingChanged(

const ContentSettingsPattern& secondary_pattern,

ContentSettingsType content_type,

std::string resource_identifier) {

- FOR_EACH_OBSERVER(content_settings::Observer,

- observers_,

- OnContentSettingChanged(primary_pattern,

- secondary_pattern,

- content_type,

- resource_identifier));

+ for (content_settings::Observer& observer : observers_) {

+ observer.OnContentSettingChanged(primary_pattern, secondary_pattern,

+ content_type, resource_identifier);

+ }

}

HostContentSettingsMap::~HostContentSettingsMap() {