Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: media/blink/webmediaplayer_impl.h

Issue 2439543003: Do not use overlays when VR shell is enabled. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_impl.h
diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h
index 020adcea097348c4a25ddcf5e7fe15aac47540d1..a1e4628655cb72311cb5017b73014844ae564254 100644
--- a/media/blink/webmediaplayer_impl.h
+++ b/media/blink/webmediaplayer_impl.h
@@ -207,6 +207,7 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
PipelineStatus status);
gfx::Size GetCanvasSize() const;
void SetDeviceScaleFactor(float scale_factor);
+ void SetEnableFullscreenOverlays(bool enable_overlays);
void setPoster(const blink::WebURL& poster) override;
void SetUseFallbackPath(bool use_fallback_path);
#endif
@@ -535,9 +536,9 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
// Force to use SurfaceView instead of SurfaceTexture on Android.
bool force_video_overlays_;
- // Prevent use of SurfaceView on Android. (Ignored when
+ // Allow use of SurfaceView on Android. (Ignored when
ddorwin 2016/12/15 01:23:52 s/Allow use of/Use/ The comment is very Android-s
amp 2016/12/15 21:49:02 I made an attempt at cleaning up the comments. Pe
// |force_video_overlays_| is true.)
- bool disable_fullscreen_video_overlays_;
+ bool enable_fullscreen_video_overlays_;
// Suppresses calls to OnPipelineError() after destruction / shutdown has been
// started; prevents us from spuriously logging errors that are transient or

Powered by Google App Engine
This is Rietveld 408576698