Do not use overlays when VR shell is enabled.

media/blink/webmediaplayer_impl.cc

Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index 03b11fb029fee3a10beeb932a0c0a33fb3d41955..fa12178255f97ddede47514fed05d294c6fc3dfe 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -250,8 +250,8 @@ WebMediaPlayerImpl::WebMediaPlayerImpl(
   force_video_overlays_ = base::CommandLine::ForCurrentProcess()->HasSwitch(

[ddorwin, 2016/12/15 01:23:52]

Even more so than base:Features, command line switches should not be accessed in
media/.

I filed https://bugs.chromium.org/p/chromium/issues/detail?id=674349 to switch
this one.

If we had all of this set in one place, we could use this being true to cause
enable_fullscreen_video_overlays_ to be set to true and ignore all other logic
for setting that value. That would allow us to simplify lines 348 and 355 and
maybe simplify the member description.

[amp, 2016/12/15 21:49:02]

Ack. It seems to operate slightly differently by creating the surface up front
(on line 1569 in the 'CreateRenderer' method) and then stops creating and
removing surface on lines 348 and 355.  I agree it is confusing and a few of my
patches probably break it (I think the latest few are fine).

So I'll leave cleaning up the flag to a future change.  :)

       switches::kForceVideoOverlays);
 
-  disable_fullscreen_video_overlays_ =
-      !base::FeatureList::IsEnabled(media::kOverlayFullscreenVideo);
+  enable_fullscreen_video_overlays_ =
+      base::FeatureList::IsEnabled(media::kOverlayFullscreenVideo);
 
   if (delegate_)
     delegate_id_ = delegate_->AddObserver(this);
@@ -345,14 +345,14 @@ void WebMediaPlayerImpl::DisableOverlay() {
 }
 
 void WebMediaPlayerImpl::enteredFullscreen() {
-  if (!force_video_overlays_ && !disable_fullscreen_video_overlays_)
+  if (!force_video_overlays_ && enable_fullscreen_video_overlays_)
     EnableOverlay();
   if (observer_)
     observer_->OnEnteredFullscreen();
 }
 
 void WebMediaPlayerImpl::exitedFullscreen() {
-  if (!force_video_overlays_ && !disable_fullscreen_video_overlays_)
+  if (!force_video_overlays_ && enable_fullscreen_video_overlays_)
     DisableOverlay();
   if (observer_)
     observer_->OnExitedFullscreen();
@@ -1467,6 +1467,10 @@ void WebMediaPlayerImpl::SetDeviceScaleFactor(float scale_factor) {
   cast_impl_.SetDeviceScaleFactor(scale_factor);
 }
 
+void WebMediaPlayerImpl::SetEnableFullscreenOverlays(bool enable_overlays) {
+  enable_fullscreen_video_overlays_ = enable_overlays;
+}
+
 void WebMediaPlayerImpl::setPoster(const blink::WebURL& poster) {
   cast_impl_.setPoster(poster);
 }