Do not use overlays when VR shell is enabled.

content/renderer/render_frame_impl.cc

Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 0179a9c1a5568f865c138447966a8f0d0b83418a..088a0c206bd5f4c64810ac1e5c8b3d80d452f0ea 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2857,6 +2857,12 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
       GetWebMediaPlayerDelegate()->AsWeakPtr(),
       std::move(media_renderer_factory), url_index_, params);
 
+
+  // TODO(crbug/673886): Re-enable overlays with VR shell enabled when VR

[ddorwin, 2016/12/15 01:23:52]

crbug.com so it is clickable.

[amp, 2016/12/15 21:49:02]

Done.

+  // shell's video reprojection surface is enabled.
+  media_player->SetEnableFullscreenOverlays(

[ddorwin, 2016/12/15 01:23:52]

This forcibly overrides the current (default) setting and potentially future
changes (none exist at the moment) regardless of the VrShell flag.

To fix this, we need to Set(false) iff VrShell is enabled.

However, such subtleties are a good argument for having all the logic for this
setting in exactly one place. That would also make it clear that we need to
correctly handle the feature flag metrics.

[amp, 2016/12/15 21:49:02]

Ok.  I'll pull back out the overlay feature check here and do the logic for
making sure we have the right value being passed into the setter.

I'll also update the TODO that we should remove this after vr shell is fixed and
move the overlay feature check back into constructor (per an ealier comment form
liberato@).

+      !base::FeatureList::IsEnabled(features::kVrShell));
+
 #if defined(OS_ANDROID)  // WMPI_CAST
   media_player->SetMediaPlayerManager(GetMediaPlayerManager());
   media_player->SetDeviceScaleFactor(render_view_->GetDeviceScaleFactor());