Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3945)

Unified Diff: blimp/common/proto/grpc_service.proto

Issue 2439403003: Refactor BlimpConnection to TCPConnection (Closed)
Patch Set: Sync merge Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/common/proto/grpc_service.proto
diff --git a/blimp/common/proto/common.proto b/blimp/common/proto/grpc_service.proto
similarity index 55%
copy from blimp/common/proto/common.proto
copy to blimp/common/proto/grpc_service.proto
index 2684302d65efa3c23ef949c266c2ec6081f20e77..50f762f62f232b89447c5d4fdcbe60c9d65fd4c2 100644
--- a/blimp/common/proto/common.proto
+++ b/blimp/common/proto/grpc_service.proto
@@ -1,13 +1,17 @@
// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-//
-// Message definitions shared across proto files.
-syntax = "proto2";
+syntax = "proto3";
Garrett Casto 2016/10/25 18:33:50 Also feels like this should be in the next CL. Als
perumaal 2016/10/25 23:02:38 This matches the non-Chromium proto as is for now.
option optimize_for = LITE_RUNTIME;
package blimp;
-message EmptyMessage {}
+message HeliumWrapper {
+ bytes serialized_helium_message = 1;
+}
+
+service GrpcService {
Kevin M 2016/10/25 18:49:22 This name seems too generic, as it could easily be
perumaal 2016/10/25 23:02:39 Done.
+ rpc Stream(stream HeliumWrapper) returns (stream HeliumWrapper) {}
+}

Powered by Google App Engine
This is Rietveld 408576698