blimp/common/proto/grpc_service.proto - Issue 2439403003: Refactor BlimpConnection to TCPConnection

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/common/proto/grpc_service.proto

Issue 2439403003: Refactor BlimpConnection to TCPConnection (Closed)

Patch Set: Sync merge Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 //

5 // Message definitions shared across proto files.

6	4

7 syntax = "proto2";	5 syntax = "proto3";
	Garrett Casto 2016/10/25 18:33:50 Also feels like this should be in the next CL. Als Also feels like this should be in the next CL. Also, if we are trying to use the same gRPC service as HeliumTransport, we should use the message definition at go/helium-transport. perumaal 2016/10/25 23:02:38 This matches the non-Chromium proto as is for now. Show quoted text On 2016/10/25 18:33:50, Garrett Casto wrote: > Also feels like this should be in the next CL. Also, if we are trying to use the > same gRPC service as HeliumTransport, we should use the message definition at > go/helium-transport. This matches the non-Chromium proto as is for now. When we 'upgrade' the other proto, I will make a change here as well.
8	6

9 option optimize_for = LITE_RUNTIME;	7 option optimize_for = LITE_RUNTIME;

10	8

11 package blimp;	9 package blimp;

12	10

13 message EmptyMessage {}	11 message HeliumWrapper {

	12 bytes serialized_helium_message = 1;

	13 }

	14

	15 service GrpcService {
	Kevin M 2016/10/25 18:49:22 This name seems too generic, as it could easily be This name seems too generic, as it could easily be confused for a GRPC base class. perumaal 2016/10/25 23:02:39 Done. Show quoted text On 2016/10/25 18:49:22, Kevin M wrote: > This name seems too generic, as it could easily be confused for a GRPC base > class. Done.
	16 rpc Stream(stream HeliumWrapper) returns (stream HeliumWrapper) {}

	17 }

OLD	NEW

« blimp/common/proto/BUILD.gn ('K') | « blimp/common/proto/BUILD.gn ('k') | blimp/engine/app/switches.h » ('j') | blimp/engine/browser_tests/blimp_browser_test.cc » ('J')