Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: blimp/engine/browser_tests/blimp_browser_test.cc

Issue 2439403003: Refactor BlimpConnection to TCPConnection (Closed)
Patch Set: Sync merge Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« blimp/common/proto/grpc_service.proto ('K') | « blimp/engine/app/switches.cc ('k') | blimp/engine/session/blimp_engine_session.cc » ('j') | blimp/engine/session/blimp_engine_session.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/browser_tests/blimp_browser_test.cc
diff --git a/blimp/engine/browser_tests/blimp_browser_test.cc b/blimp/engine/browser_tests/blimp_browser_test.cc
index e8ed5b9eaa55cb6c4b6f4c94f8933a0dfa56b68d..aaf7b1bb6d2ed9348af93f443ed9dca722ee9de9 100644
--- a/blimp/engine/browser_tests/blimp_browser_test.cc
+++ b/blimp/engine/browser_tests/blimp_browser_test.cc
@@ -93,6 +93,8 @@ void BlimpBrowserTest::SetUpCommandLine(base::CommandLine* command_line) {
command_line->AppendSwitchASCII(blimp::engine::kEnginePort, "0");
}
+ // TODO(perumaal): Switch to gRPC when it's ready.
Kevin M 2016/10/25 18:49:22 Make a crbug link?
perumaal 2016/10/25 23:02:39 Thanks for the idea.
+
base::FilePath src_root;
PathService::Get(base::DIR_SOURCE_ROOT, &src_root);
command_line->AppendSwitchASCII(
« blimp/common/proto/grpc_service.proto ('K') | « blimp/engine/app/switches.cc ('k') | blimp/engine/session/blimp_engine_session.cc » ('j') | blimp/engine/session/blimp_engine_session.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698