[windows] Make most file_win.cc functions use malloc for string conversions.

[windows] Make most file_win.cc functions use malloc for string conversions.

They have been using Dart_ScopeAllocate(), which makes them impossible
to use outside of a scope.

Also turn on inlining in the GN Debug windows build to match the gyp build
and speed things up a bit.

R=asiva@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/b6ea87c44415b0950fcf17579072c733c0ecb5c0

[zra, 2016-10-21 20:18:52]

Description was changed from

==========
[windows] Make most file_win.cc functions use malloc for string conversions.

They have been using Dart_ScopeAllocate(), which makes them impossible
to use outside of a scope.
==========

to

==========
[windows] Make most file_win.cc functions use malloc for string conversions.

They have been using Dart_ScopeAllocate(), which makes them impossible
to use outside of a scope.

Also turn on inlining in the GN Debug windows build to match the gyp build
and speed things up a bit.
==========

[zra, 2016-10-21 20:19:27]

zra@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com

[zra, 2016-10-21 20:19:27]

zra@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com

[rmacnak, 2016-10-21 21:33:55]

LGTM

[siva, 2016-10-21 21:41:26]

lgtm

https://codereview.chromium.org/2439173002/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/2439173002/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:735: # The only difference on windows is that the
inlining is less agressive.
aggressive

[zra, 2016-10-21 21:54:10]

https://codereview.chromium.org/2439173002/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/2439173002/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:735: # The only difference on windows is that the
inlining is less agressive.
On 2016/10/21 21:41:26, siva wrote:
> aggressive

Done.

[zra, 2016-10-21 21:55:43]

Description was changed from

==========
[windows] Make most file_win.cc functions use malloc for string conversions.

They have been using Dart_ScopeAllocate(), which makes them impossible
to use outside of a scope.

Also turn on inlining in the GN Debug windows build to match the gyp build
and speed things up a bit.
==========

to

==========
[windows] Make most file_win.cc functions use malloc for string conversions.

They have been using Dart_ScopeAllocate(), which makes them impossible
to use outside of a scope.

Also turn on inlining in the GN Debug windows build to match the gyp build
and speed things up a bit.

R=asiva@google.com, rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b6ea87c44415b0950fcf17579072c733c0ecb5c0
==========

[zra, 2016-10-21 21:55:44]

Committed patchset #2 (id:20001) manually as
b6ea87c44415b0950fcf17579072c733c0ecb5c0 (presubmit successful).