[windows] Make most file_win.cc functions use malloc for string conversions.

runtime/bin/directory_win.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_WINDOWS)
 
 #include "bin/directory.h"
 #include "bin/file.h"
 #include "bin/utils.h"
@@ skipping 32 matching lines @@
   return reinterpret_cast<wchar_t*>(data_);
 }
 
 
 const char* PathBuffer::AsScopedString() const {
   return StringUtilsWin::WideToUtf8(AsStringW());
 }
 
 
 bool PathBuffer::Add(const char* name) {
-  const wchar_t* wide_name = StringUtilsWin::Utf8ToWide(name);
-  return AddW(wide_name);
+  Utf8ToWideScope wide_name(name);
+  return AddW(wide_name.wide());
 }
 
 
 bool PathBuffer::AddW(const wchar_t* name) {
   wchar_t* data = AsStringW();
   int written = _snwprintf(data + length_,
                            MAX_LONG_PATH - length_,
                            L"%s",
                            name);
   data[MAX_LONG_PATH] = L'\0';
@@ skipping 305 matching lines @@
       return Directory::UNKNOWN;
     }
   }
   bool exists = (attributes & FILE_ATTRIBUTE_DIRECTORY) != 0;
   exists = exists && !IsBrokenLink(dir_name);
   return exists ? Directory::EXISTS : Directory::DOES_NOT_EXIST;
 }
 
 
 Directory::ExistsResult Directory::Exists(const char* dir_name) {
-  const wchar_t* system_name = StringUtilsWin::Utf8ToWide(dir_name);
-  return ExistsHelper(system_name);
+  Utf8ToWideScope system_name(dir_name);
+  return ExistsHelper(system_name.wide());
 }
 
 
 char* Directory::CurrentNoScope() {
   int length = GetCurrentDirectoryW(0, NULL);
   if (length == 0) {
     return NULL;
   }
   wchar_t* current = new wchar_t[length + 1];
   GetCurrentDirectoryW(length + 1, current);
@@ skipping 13 matching lines @@
   }
   wchar_t* current;
   current = reinterpret_cast<wchar_t*>(
       Dart_ScopeAllocate((length + 1) * sizeof(*current)));
   GetCurrentDirectoryW(length + 1, current);
   return StringUtilsWin::WideToUtf8(current);
 }
 
 
 bool Directory::SetCurrent(const char* path) {
-  const wchar_t* system_path = StringUtilsWin::Utf8ToWide(path);
-  bool result = SetCurrentDirectoryW(system_path) != 0;
+  Utf8ToWideScope system_path(path);
+  bool result = SetCurrentDirectoryW(system_path.wide()) != 0;
   return result;
 }
 
 
 bool Directory::Create(const char* dir_name) {
-  const wchar_t* system_name = StringUtilsWin::Utf8ToWide(dir_name);
-  int create_status = CreateDirectoryW(system_name, NULL);
+  Utf8ToWideScope system_name(dir_name);
+  int create_status = CreateDirectoryW(system_name.wide(), NULL);
   // If the directory already existed, treat it as a success.
   if ((create_status == 0) &&
       (GetLastError() == ERROR_ALREADY_EXISTS) &&
-      (ExistsHelper(system_name) == EXISTS)) {
+      (ExistsHelper(system_name.wide()) == EXISTS)) {
     return true;
   }
   return (create_status != 0);
 }
 
 
 const char* Directory::SystemTemp() {
   PathBuffer path;
   // Remove \ at end.
   path.Reset(GetTempPathW(MAX_LONG_PATH, path.AsStringW()) - 1);
   return path.AsScopedString();
 }
 
 
 const char* Directory::CreateTemp(const char* prefix) {
   // Returns a new, unused directory name, adding characters to the
   // end of prefix.
   // Creates this directory, with a default security
   // descriptor inherited from its parent directory.
   // The return value is Dart_ScopeAllocated.
   PathBuffer path;
-  const wchar_t* system_prefix = StringUtilsWin::Utf8ToWide(prefix);
-  if (!path.AddW(system_prefix)) {
+  Utf8ToWideScope system_prefix(prefix);
+  if (!path.AddW(system_prefix.wide())) {
     return NULL;
   }
 
   // Length of xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx is 36.
   if (path.length() > MAX_LONG_PATH - 36) {
     return NULL;
   }
 
   UUID uuid;
   RPC_STATUS status = UuidCreateSequential(&uuid);
@@ skipping 13 matching lines @@
   RpcStringFreeW(&uuid_string);
   if (!CreateDirectoryW(path.AsStringW(), NULL)) {
     return NULL;
   }
   return path.AsScopedString();
 }
 
 
 bool Directory::Delete(const char* dir_name, bool recursive) {
   bool result = false;
-  const wchar_t* system_dir_name = StringUtilsWin::Utf8ToWide(dir_name);
+  Utf8ToWideScope system_dir_name(dir_name);
   if (!recursive) {
     if (File::GetType(dir_name, true) == File::kIsDirectory) {
-      result = (RemoveDirectoryW(system_dir_name) != 0);
+      result = (RemoveDirectoryW(system_dir_name.wide()) != 0);
     } else {
       SetLastError(ERROR_FILE_NOT_FOUND);
     }
   } else {
     PathBuffer path;
-    if (path.AddW(system_dir_name)) {
+    if (path.AddW(system_dir_name.wide())) {
       result = DeleteRecursively(&path);
     }
   }
   return result;
 }
 
 
 bool Directory::Rename(const char* path, const char* new_path) {
-  const wchar_t* system_path = StringUtilsWin::Utf8ToWide(path);
-  const wchar_t* system_new_path = StringUtilsWin::Utf8ToWide(new_path);
-  ExistsResult exists = ExistsHelper(system_path);
+  Utf8ToWideScope system_path(path);
+  Utf8ToWideScope system_new_path(new_path);
+  ExistsResult exists = ExistsHelper(system_path.wide());
   if (exists != EXISTS) {
     return false;
   }
-  ExistsResult new_exists = ExistsHelper(system_new_path);
+  ExistsResult new_exists = ExistsHelper(system_new_path.wide());
   // MoveFile does not allow replacing exising directories. Therefore,
   // if the new_path is currently a directory we need to delete it
   // first.
   if (new_exists == EXISTS) {
     bool success = Delete(new_path, true);
     if (!success) {
       return false;
     }
   }
   DWORD flags = MOVEFILE_WRITE_THROUGH;
   int move_status =
-      MoveFileExW(system_path, system_new_path, flags);
+      MoveFileExW(system_path.wide(), system_new_path.wide(), flags);
   return (move_status != 0);
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_WINDOWS)