Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/compiler/BUILD.gn

Issue 2439173002: [windows] Make most file_win.cc functions use malloc for string conversions. (Closed)
Patch Set: Fix typo Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/directory_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index a2f8b130e88f5b2a3db974d1229c5c1f0e87c619..873dc4cef516a5bc857b2d0b7221cb951cc09b11 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -732,10 +732,11 @@ config("optimize") {
# Turn off optimizations.
config("no_optimize") {
if (is_win) {
+ # The only difference on windows is that the inlining is less aggressive.
+ # (We accept the default level). Otherwise it is very slow.
cflags = [
"/O2", # Do some optimizations.
"/Oy-", # Disable omitting frame pointers, must be after /O2.
- "/Ob0", # Disable all inlining (on by default).
]
} else if (is_android) {
# On Android we kind of optimize some things that don't affect debugging
« no previous file with comments | « no previous file | runtime/bin/directory_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698