Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2831)

Unified Diff: appengine/findit/handlers/flake/test/check_flake_test.py

Issue 2438673004: [Findit] Post analysis results of flakes to bug filed by chromium-try-flakes. (Closed)
Patch Set: Add a config flag to enable/disable updating monorail bug. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/handlers/flake/check_flake.py ('k') | appengine/findit/handlers/test/config_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/handlers/flake/test/check_flake_test.py
diff --git a/appengine/findit/handlers/flake/test/check_flake_test.py b/appengine/findit/handlers/flake/test/check_flake_test.py
index 319f10888cb8c431e9d7b788e9152be1d5ab8639..c2a6041f401123351fcac85b5f6c691f630aa090 100644
--- a/appengine/findit/handlers/flake/test/check_flake_test.py
+++ b/appengine/findit/handlers/flake/test/check_flake_test.py
@@ -93,11 +93,7 @@ class CheckFlakeTest(wf_testcase.WaterfallTestCase):
analysis.Save()
response = self.test_app.get('/waterfall/check-flake', params={
- 'master_name': master_name,
- 'builder_name': builder_name,
- 'build_number': build_number,
- 'step_name': step_name,
- 'test_name': test_name,
+ 'key': analysis.key.urlsafe(),
'format': 'json'})
expected_check_flake_result = {
@@ -158,7 +154,7 @@ class CheckFlakeTest(wf_testcase.WaterfallTestCase):
previous_analysis = MasterFlakeAnalysis.Create(
master_name, builder_name, build_number - 1, step_name, test_name)
data_point = DataPoint()
- data_point.build_number = int(build_number)
+ data_point.build_number = build_number - 1
data_point.pass_rate = success_rate
previous_analysis.data_points.append(data_point)
previous_analysis.status = analysis_status.COMPLETED
@@ -184,11 +180,11 @@ class CheckFlakeTest(wf_testcase.WaterfallTestCase):
'format': 'json'})
expected_check_flake_result = {
- 'pass_rates': [[int(build_number), success_rate]],
+ 'pass_rates': [[build_number - 1, success_rate]],
'analysis_status': STATUS_TO_DESCRIPTION.get(previous_analysis.status),
'master_name': master_name,
'builder_name': builder_name,
- 'build_number': int(build_number),
+ 'build_number': build_number - 1,
'step_name': step_name,
'test_name': test_name,
'request_time': '2016-10-01 12:10:00 UTC',
« no previous file with comments | « appengine/findit/handlers/flake/check_flake.py ('k') | appengine/findit/handlers/test/config_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698