[Findit] Post analysis results of flakes to bug filed by chromium-try-flakes.

appengine/findit/handlers/flake/test/check_flake_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import mock
 import re
 
 import webapp2
 import webtest
@@ skipping 75 matching lines @@
     analysis.data_points.append(data_point)
     analysis.status = analysis_status.COMPLETED
     analysis.suspected_flake_build_number = 100
     analysis.request_time = datetime.datetime(2016, 10, 01, 12, 10, 00)
     analysis.start_time = datetime.datetime(2016, 10, 01, 12, 10, 05)
     analysis.end_time = datetime.datetime(2016, 10, 01, 13, 10, 00)
     analysis.algorithm_parameters = {'iterations_to_rerun': 100}
     analysis.Save()
 
     response = self.test_app.get('/waterfall/check-flake', params={
-        'master_name': master_name,
-        'builder_name': builder_name,
-        'build_number': build_number,
-        'step_name': step_name,
-        'test_name': test_name,
+        'key': analysis.key.urlsafe(),
         'format': 'json'})
 
     expected_check_flake_result = {
         'pass_rates': [[int(build_number), success_rate]],
         'analysis_status': STATUS_TO_DESCRIPTION.get(analysis.status),
         'master_name': master_name,
         'builder_name': builder_name,
         'build_number': int(build_number),
         'step_name': step_name,
         'test_name': test_name,
@@ skipping 40 matching lines @@
     master_name = 'm'
     builder_name = 'b'
     build_number = 123
     step_name = 's'
     test_name = 't'
     success_rate = 0.9
 
     previous_analysis = MasterFlakeAnalysis.Create(
         master_name, builder_name, build_number - 1, step_name, test_name)
     data_point = DataPoint()
-    data_point.build_number = int(build_number)
+    data_point.build_number = build_number - 1
     data_point.pass_rate = success_rate
     previous_analysis.data_points.append(data_point)
     previous_analysis.status = analysis_status.COMPLETED
     previous_analysis.suspected_flake_build_number = 100
     previous_analysis.request_time = datetime.datetime(2016, 10, 01, 12, 10, 00)
     previous_analysis.start_time = datetime.datetime(2016, 10, 01, 12, 10, 05)
     previous_analysis.end_time = datetime.datetime(2016, 10, 01, 13, 10, 00)
     previous_analysis.algorithm_parameters = {'iterations_to_rerun': 100}
     previous_analysis.Save()
 
     previous_request = FlakeAnalysisRequest.Create(test_name, False, None)
     previous_request.AddBuildStep(
         master_name, builder_name, build_number, step_name, None)
     previous_request.analyses.append(previous_analysis.key)
     previous_request.Save()
 
     response = self.test_app.get('/waterfall/check-flake', params={
         'master_name': master_name,
         'builder_name': builder_name,
         'build_number': build_number,
         'step_name': step_name,
         'test_name': test_name,
         'format': 'json'})
 
     expected_check_flake_result = {
-        'pass_rates': [[int(build_number), success_rate]],
+        'pass_rates': [[build_number - 1, success_rate]],
         'analysis_status': STATUS_TO_DESCRIPTION.get(previous_analysis.status),
         'master_name': master_name,
         'builder_name': builder_name,
-        'build_number': int(build_number),
+        'build_number': build_number - 1,
         'step_name': step_name,
         'test_name': test_name,
         'request_time': '2016-10-01 12:10:00 UTC',
         'task_number': 1,
         'error': None,
         'iterations_to_rerun': 100,
         'pending_time': '00:00:05',
         'duration': '00:59:55',
         'suspected_flake': {
             'build_number': 100,
@@ skipping 100 matching lines @@
     self.assertEqual(
         CheckFlake()._ValidateInput(
             'm', 'b', '1', 's', None, '').get('data', {}).get('error_message'),
         'Test name must be specified')
     self.assertEqual(
         CheckFlake()._ValidateInput(
             'm', 'b', '1', 's', 't', 'a').get('data', {}).get('error_message'),
         'Bug id (optional) must be an int')