Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5282)

Unified Diff: appengine/findit/handlers/test/config_test.py

Issue 2438673004: [Findit] Post analysis results of flakes to bug filed by chromium-try-flakes. (Closed)
Patch Set: Add a config flag to enable/disable updating monorail bug. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/handlers/test/config_test.py
diff --git a/appengine/findit/handlers/test/config_test.py b/appengine/findit/handlers/test/config_test.py
index 2b9f1e316f6a913bf4209d52a8748c36525624e0..6ed0d1d85ffbf7460be1a7135373032bdc0502a6 100644
--- a/appengine/findit/handlers/test/config_test.py
+++ b/appengine/findit/handlers/test/config_test.py
@@ -89,7 +89,8 @@ _MOCK_CHECK_FLAKE_SETTINGS = {
'max_flake_in_a_row': 4,
'max_stable_in_a_row': 4,
'iterations_to_rerun': 100,
- 'max_build_numbers_to_look_back': 1000
+ 'max_build_numbers_to_look_back': 1000,
+ 'update_monorail_bug': True,
}
_MOCK_VERSION_NUMBER = 12
@@ -818,6 +819,16 @@ class ConfigTest(testing.AppengineTestCase):
'iterations_to_rerun': 4,
'max_build_numbers_to_look_back': 'a' # Should be an int.
}))
+ self.assertFalse(config._ValidateCheckFlakeSettings(
+ {
+ 'lower_flake_threshold': 0.02,
+ 'upper_flake_threshold': 0.98,
+ 'max_flake_in_a_row': 4,
+ 'max_stable_in_a_row': 4,
+ 'iterations_to_rerun': 100,
+ 'max_build_numbers_to_look_back': 1000,
+ 'update_monorail_bug': 'True', # Should be a bool.
+ }))
self.assertTrue(config._ValidateCheckFlakeSettings(
{
'lower_flake_threshold': 0.02,
@@ -825,5 +836,6 @@ class ConfigTest(testing.AppengineTestCase):
'max_flake_in_a_row': 4,
'max_stable_in_a_row': 4,
'iterations_to_rerun': 100,
- 'max_build_numbers_to_look_back': 1000
+ 'max_build_numbers_to_look_back': 1000,
+ 'update_monorail_bug': True,
}))
« no previous file with comments | « appengine/findit/handlers/flake/test/check_flake_test.py ('k') | appengine/findit/model/flake/master_flake_analysis.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698