[Fetch, Loader] Expect on-heap objects will never get destroyed with a reference

[Fetch, Loader] Expect on-heap objects will never get destroyed with a reference

Many classes have been to moved to Oilpan but some comments remain stale. This
CL mainly resoves / updates such stale comments.

This CL also removes an unnecessary copy to deal with the case where a Resource
object is destructed.

BUG=None

Committed: https://crrev.com/e950de6820ea240a82d494a1504d8e4fcbccacd7
Cr-Commit-Position: refs/heads/master@{#427937}

[yhirano, 2016-10-20 07:22:59]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 07:23:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-10-20 08:13:11]

Description was changed from

==========
[Fetch, Loader] Expect on-heap objects will never get destroyed with a reference

Many classes have been to moved to Oilpan but some comments remain stale. This
CL mainly resoves / updates such stale comments.

This CL also removes an unnecessary copy to deal with the case where an object
is destructed synchronously.

BUG=None
==========

to

==========
[Fetch, Loader] Expect on-heap objects will never get destroyed with a reference

Many classes have been to moved to Oilpan but some comments remain stale. This
CL mainly resoves / updates such stale comments.

This CL also removes an unnecessary copy to deal with the case where a Resource
object is destructed.

BUG=None
==========

[yhirano, 2016-10-20 08:41:01]

yhirano@chromium.org changed reviewers:
+ hiroshige@chromium.org

[commit-bot: I haz the power, 2016-10-20 08:46:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 08:46:39]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-10-21 05:45:14]

Probably we can refer to the ResourceClient oilpanization crbug in BUG=.

https://codereview.chromium.org/2436623004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/FrameLoader.cpp (left):

https://codereview.chromium.org/2436623004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:616: return;  // We are
being destroyed by something checkCompleted called.
If this |if| block remains, then should we leave some comments that mentions
this condition holds due to something checkCompleted called (if not destroyed
though)?

https://codereview.chromium.org/2436623004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/ThreadableLoader.h (left):

https://codereview.chromium.org/2436623004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/ThreadableLoader.h:172: //
ThreadableLoaderClient methods:
Isn't the part of "ThreadableLoaderClient methods may call cancel()" still
valid?

[yhirano, 2016-10-26 10:55:32]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 10:55:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-10-26 11:09:34]

https://codereview.chromium.org/2436623004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/FrameLoader.cpp (left):

https://codereview.chromium.org/2436623004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:616: return;  // We are
being destroyed by something checkCompleted called.
On 2016/10/21 05:45:14, hiroshige wrote:
> If this |if| block remains, then should we leave some comments that mentions
> this condition holds due to something checkCompleted called (if not destroyed
> though)?

I'm not 100% sure but it looks FrameLoaderClient::runScriptsAtDocumentReady may
invalidate the frame, too. Regardless of the reason, we shouldn't run L620 if
m_frame->view() is null.

https://cs.chromium.org/chromium/src/content/public/renderer/content_renderer...

https://codereview.chromium.org/2436623004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/ThreadableLoader.h (left):

https://codereview.chromium.org/2436623004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/ThreadableLoader.h:172: //
ThreadableLoaderClient methods:
On 2016/10/21 05:45:14, hiroshige wrote:
> Isn't the part of "ThreadableLoaderClient methods may call cancel()" still
> valid?

You're right, thanks.

[commit-bot: I haz the power, 2016-10-26 12:15:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 12:15:50]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-10-27 03:16:16]

lgtm.

[yhirano, 2016-10-27 04:20:05]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-10-27 04:20:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 04:24:37]

Description was changed from

==========
[Fetch, Loader] Expect on-heap objects will never get destroyed with a reference

Many classes have been to moved to Oilpan but some comments remain stale. This
CL mainly resoves / updates such stale comments.

This CL also removes an unnecessary copy to deal with the case where a Resource
object is destructed.

BUG=None
==========

to

==========
[Fetch, Loader] Expect on-heap objects will never get destroyed with a reference

Many classes have been to moved to Oilpan but some comments remain stale. This
CL mainly resoves / updates such stale comments.

This CL also removes an unnecessary copy to deal with the case where a Resource
object is destructed.

BUG=None
==========

[commit-bot: I haz the power, 2016-10-27 04:24:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-27 04:27:47]

Description was changed from

==========
[Fetch, Loader] Expect on-heap objects will never get destroyed with a reference

Many classes have been to moved to Oilpan but some comments remain stale. This
CL mainly resoves / updates such stale comments.

This CL also removes an unnecessary copy to deal with the case where a Resource
object is destructed.

BUG=None
==========

to

==========
[Fetch, Loader] Expect on-heap objects will never get destroyed with a reference

Many classes have been to moved to Oilpan but some comments remain stale. This
CL mainly resoves / updates such stale comments.

This CL also removes an unnecessary copy to deal with the case where a Resource
object is destructed.

BUG=None

Committed: https://crrev.com/e950de6820ea240a82d494a1504d8e4fcbccacd7
Cr-Commit-Position: refs/heads/master@{#427937}
==========

[commit-bot: I haz the power, 2016-10-27 04:27:47]

Patchset 2 (id:??) landed as
https://crrev.com/e950de6820ea240a82d494a1504d8e4fcbccacd7
Cr-Commit-Position: refs/heads/master@{#427937}