[Fetch, Loader] Expect on-heap objects will never get destroyed with a reference

third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013, Intel Corporation
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 55 matching lines @@
   static DocumentThreadableLoader* create(Document&,
                                           ThreadableLoaderClient*,
                                           const ThreadableLoaderOptions&,
                                           const ResourceLoaderOptions&);
   ~DocumentThreadableLoader() override;
 
   void start(const ResourceRequest&) override;
 
   void overrideTimeout(unsigned long timeout) override;
 
-  // |this| may be dead after calling this method in async mode.
   void cancel() override;
   void setDefersLoading(bool);
 
   DECLARE_TRACE();
 
  private:
   enum BlockingBehavior { LoadSynchronously, LoadAsynchronously };
 
   DocumentThreadableLoader(Document&,
                            ThreadableLoaderClient*,
                            BlockingBehavior,
                            const ThreadableLoaderOptions&,
                            const ResourceLoaderOptions&);
 
   void clear();
 
   // ResourceClient
-  //
-  // |this| may be dead after calling this method.
   void notifyFinished(Resource*) override;
 
   String debugName() const override { return "DocumentThreadableLoader"; }
 
   // RawResourceClient
-  //
-  // |this| may be dead after calling these methods.
   void dataSent(Resource*,
                 unsigned long long bytesSent,
                 unsigned long long totalBytesToBeSent) override;
   void responseReceived(Resource*,
                         const ResourceResponse&,
                         std::unique_ptr<WebDataConsumerHandle>) override;
   void setSerializedCachedMetadata(Resource*, const char*, size_t) override;
   void dataReceived(Resource*, const char* data, size_t dataLength) override;
   bool redirectReceived(Resource*,
                         const ResourceRequest&,
                         const ResourceResponse&) override;
   void redirectBlocked() override;
   void dataDownloaded(Resource*, int) override;
   void didReceiveResourceTiming(Resource*, const ResourceTimingInfo&) override;
 
-  // |this| may be dead after calling this method in async mode.
   void cancelWithError(const ResourceError&);
 
   // Notify Inspector and log to console about resource response. Use this
   // method if response is not going to be finished normally.
   void reportResponseReceived(unsigned long identifier,
                               const ResourceResponse&);
 
   // Methods containing code to handle resource fetch results which are common
   // to both sync and async mode.
-  //
-  // |this| may be dead after calling these method in async mode.
   void handleResponse(unsigned long identifier,
                       const ResourceResponse&,
                       std::unique_ptr<WebDataConsumerHandle>);
   void handleReceivedData(const char* data, size_t dataLength);
   void handleSuccessfulFinish(unsigned long identifier, double finishTime);
 
-  // |this| may be dead after calling this method.
   void didTimeout(TimerBase*);
   // Calls the appropriate loading method according to policy and data about
   // origin. Only for handling the initial load (including fallback after
   // consulting ServiceWorker).
-  //
-  // |this| may be dead after calling this method in async mode.
   void dispatchInitialRequest(const ResourceRequest&);
-  // |this| may be dead after calling this method in async mode.
   void makeCrossOriginAccessRequest(const ResourceRequest&);
   // Loads m_fallbackRequestForServiceWorker.
-  //
-  // |this| may be dead after calling this method in async mode.
   void loadFallbackRequestForServiceWorker();
   // Loads m_actualRequest.
   void loadActualRequest();
   // Clears m_actualRequest and reports access control check failure to
   // m_client.
-  //
-  // |this| may be dead after calling this method in async mode.
   void handlePreflightFailure(const String& url,
                               const String& errorDescription);
   // Investigates the response for the preflight request. If successful,
   // the actual request will be made later in handleSuccessfulFinish().
-  //
-  // |this| may be dead after calling this method in async mode.
   void handlePreflightResponse(const ResourceResponse&);
-  // |this| may be dead after calling this method.
   void handleError(const ResourceError&);
 
   void loadRequestAsync(const ResourceRequest&, ResourceLoaderOptions);
   void loadRequestSync(const ResourceRequest&, ResourceLoaderOptions);
   void loadRequest(const ResourceRequest&, ResourceLoaderOptions);
   bool isAllowedRedirect(const KURL&) const;
   // Returns DoNotAllowStoredCredentials if m_forceDoNotAllowStoredCredentials
   // is set. Otherwise, just returns allowCredentials value of
   // m_resourceLoaderOptions.
   StoredCredentials effectiveAllowCredentials() const;
@@ skipping 81 matching lines @@
   // used to populate the HTTP Referer header when following the redirect.
   bool m_didRedirect;
   Referrer m_referrerAfterRedirect;
 
   RawResourceClientStateChecker m_checker;
 };
 
 }  // namespace blink
 
 #endif  // DocumentThreadableLoader_h