Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: third_party/WebKit/Source/core/loader/ThreadableLoader.h

Issue 2436623004: [Fetch, Loader] Expect on-heap objects will never get destroyed with a reference (Closed)
Patch Set: fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/ThreadableLoader.h
diff --git a/third_party/WebKit/Source/core/loader/ThreadableLoader.h b/third_party/WebKit/Source/core/loader/ThreadableLoader.h
index ef75a632ee68fcd34283f3f48b3770120b0dfd47..9e8c56c6bc826de43fc680b5f4828c4eb83a1c60 100644
--- a/third_party/WebKit/Source/core/loader/ThreadableLoader.h
+++ b/third_party/WebKit/Source/core/loader/ThreadableLoader.h
@@ -131,8 +131,6 @@ class CORE_EXPORT ThreadableLoader
WTF_MAKE_NONCOPYABLE(ThreadableLoader);
public:
- // ThreadableLoaderClient methods may not destroy the ThreadableLoader
- // instance in them.
static void loadResourceSynchronously(ExecutionContext&,
const ResourceRequest&,
ThreadableLoaderClient&,
@@ -169,10 +167,7 @@ class CORE_EXPORT ThreadableLoader
// called with a ResourceError with isCancellation() returning true
// also for cancellation happened inside the loader.)
//
- // ThreadableLoaderClient methods:
- // - may call cancel()
- // - can destroy the ThreadableLoader instance in them (by clearing
- // std::unique_ptr<ThreadableLoader>).
+ // ThreadableLoaderClient methods may call cancel().
static ThreadableLoader* create(ExecutionContext&,
ThreadableLoaderClient*,
const ThreadableLoaderOptions&,
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698