Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2434563008: Import wpt@26c8d4e87448d1c4e5ebf2ddb4917c0633c201db (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 1 month ago
Reviewers:
tkent, jsbell
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, darin-cc_chromium.org, dom-dev_chromium.org, Eric Willigers, jam, rjwright, shans, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Import wpt@26c8d4e87448d1c4e5ebf2ddb4917c0633c201db Using update-w3c-deps in Chromium 143414007952491b458bbd5bb55116fbde7d2caa. I ran update-w3c-deps and updated expectations and baselines manually on Friday last week since w3c-test-autoroller failed. Committed: https://crrev.com/31d75a6701dd1c9276ce39e8c32c3c629ff46fde Cr-Commit-Position: refs/heads/master@{#427008}

Patch Set 1 #

Patch Set 2 : Add new baselines, remove platform specific ones #

Patch Set 3 : Run rebaseline-cl again #

Patch Set 4 : Rebased #

Patch Set 5 : Update test expectations and baselines manually #

Patch Set 6 : Mark one more test as potentially timing out #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4321 lines, -242 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 2 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/WebIDL/current-realm.html View 1 chunk +145 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/WebIDL/current-realm-expected.txt View 1 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/check_stability.py View 1 chunk +284 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/ci_lint.sh View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/ci_stability.sh View 1 chunk +123 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/console/console-is-a-namespace.any.js View 1 chunk +27 lines, -0 lines 1 comment Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/Document-createElement.html View 1 chunk +332 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/Document-createElement-expected.txt View 1 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/parser/parser-constructs-custom-element-in-document-write.html View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/parser/parser-constructs-custom-element-synchronously.html View 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/parser/parser-constructs-custom-elements.html View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/parser/parser-fallsback-to-unknown-element.html View 1 chunk +91 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/parser/parser-sets-attributes-and-children.html View 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/parser/parser-uses-constructed-element.html View 1 chunk +75 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/parser/parser-uses-constructed-element-expected.txt View 1 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/parser/parser-uses-registry-of-owner-document.html View 1 chunk +126 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/parser/parser-uses-registry-of-owner-document-expected.txt View 1 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/DOMStringMap.html View 1 chunk +96 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/DOMStringMap-expected.txt View 1 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/Document.html View 2 chunks +19 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/Document-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/Element.html View 2 chunks +24 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/ElementContentEditable.html View 2 chunks +4 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/HTMLElement.html View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/HTMLElement-expected.txt View 1 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/NamedNodeMap.html View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/NamedNodeMap-expected.txt View 1 2 3 4 1 chunk +0 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/Range.html View 1 chunk +6 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/Range-expected.txt View 1 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/Selection.html View 1 chunk +32 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/resources/reactions.js View 5 chunks +57 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/custom-elements/resources/custom-elements-helpers.js View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/upgrading.html View 1 chunk +190 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/upgrading-expected.txt View 1 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/upgrading/Node-cloneNode.html View 1 chunk +185 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/custom-elements/upgrading/upgrading-parser-created-element.html View 1 chunk +97 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/dom/events/Event-dispatch-click.html View 1 chunk +119 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Node-contains.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/html/browsers/history/the-location-interface/security_location_0.htm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/html/browsers/history/the-location-interface/security_location_0-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/browsers/history/the-location-interface/security_location_0.sub.htm View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/browsers/history/the-location-interface/security_location_0.sub-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/browsers/the-window-object/security-window/window-security.html View 1 chunk +203 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/browsers/the-window-object/security-window/window-security-expected.txt View 1 1 chunk +1013 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/browsers/windows/nested-browsing-contexts/frameElement.html View 1 chunk +74 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.html View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/dom/documents/dom-tree-accessors/Document.currentScript.html View 1 chunk +211 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/document-metadata/the-base-element/base_href_specified.html View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/document-metadata/the-base-element/base_href_specified-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/interfaces/TrackEvent/constructor.html View 1 chunk +5 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/interfaces/TrackEvent/constructor-expected.txt View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/grouping-content/the-ol-element/grouping-ol.html View 1 chunk +20 lines, -35 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/grouping-content/the-ol-element/grouping-ol-expected.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/grouping-content/the-ol-element/ol.start-reflection-2.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/grouping-content/the-ol-element/ol.start-reflection-2-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/tabular-data/the-table-element/remove-row.html View 1 chunk +17 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/tabular-data/the-table-element/remove-row-expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/tabular-data/the-tbody-element/deleteRow.html View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/tabular-data/the-tr-element/deleteCell.html View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/service-workers/stub-3.1-service-worker-obj.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/service-workers/stub-3.2-navigator-service-worker.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/service-workers/stub-4.1-service-worker-global-scope.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/service-workers/stub-4.2-client.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/service-workers/stub-4.3-service-worker-clients.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/service-workers/stub-4.4-request-objects.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/service-workers/stub-4.5-response-objects.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/service-workers/stub-4.6.2-cache.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/service-workers/stub-4.6.3-cache-storage.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/service-workers/stub-4.7.1-install-phase-event.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/service-workers/stub-4.7.2.1-install-event-section.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/service-workers/stub-4.7.4.1-fetch-event-section.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/uievents/order-of-events/focus-events/focus-manual.html View 1 chunk +55 lines, -62 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/uievents/resources/eventrecorder.js View 2 chunks +34 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/web-animations/timing-model/animations/updating-the-finished-state.html View 2 chunks +98 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/workers/constructors/SharedWorker/URLMismatchError.htm View 1 chunk +20 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
qyearsley
4 years, 1 month ago (2016-10-24 00:36:13 UTC) #7
tkent
lgtm https://codereview.chromium.org/2434563008/diff/100001/third_party/WebKit/LayoutTests/imported/wpt/console/console-is-a-namespace.any.js File third_party/WebKit/LayoutTests/imported/wpt/console/console-is-a-namespace.any.js (right): https://codereview.chromium.org/2434563008/diff/100001/third_party/WebKit/LayoutTests/imported/wpt/console/console-is-a-namespace.any.js#newcode1 third_party/WebKit/LayoutTests/imported/wpt/console/console-is-a-namespace.any.js:1: "use strict"; wpt/console/ is a new directory. We ...
4 years, 1 month ago (2016-10-24 01:00:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434563008/100001
4 years, 1 month ago (2016-10-24 01:01:05 UTC) #10
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 1 month ago (2016-10-24 02:01:07 UTC) #11
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/31d75a6701dd1c9276ce39e8c32c3c629ff46fde Cr-Commit-Position: refs/heads/master@{#427008}
4 years, 1 month ago (2016-10-24 02:03:19 UTC) #13
haraken
The following tests started failing after this CL: imported/wpt/html/browsers/windows/nested-browsing-contexts/frameElement.html imported/wpt/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.html imported/wpt/html/dom/documents/dom-tree-accessors/Document.currentScript.html imported/wpt/workers/constructors/SharedWorker/URLMismatchError.htm Would you take ...
4 years, 1 month ago (2016-10-24 19:49:27 UTC) #14
qyearsley
4 years, 1 month ago (2016-10-24 20:37:43 UTC) #15
Message was sent while issue was closed.
On 2016/10/24 at 19:49:27, haraken wrote:
> The following tests started failing after this CL:
> 
> imported/wpt/html/browsers/windows/nested-browsing-contexts/frameElement.html
>
imported/wpt/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.html
> imported/wpt/html/dom/documents/dom-tree-accessors/Document.currentScript.html
> imported/wpt/workers/constructors/SharedWorker/URLMismatchError.htm
> 
> Would you take a look?

Thanks for watching this -- it looks like the change you already made is what we
want to do for now -- just mark these tests as either failing or timing out.

Powered by Google App Engine
This is Rietveld 408576698