Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/resources/reactions.js

Issue 2434563008: Import wpt@26c8d4e87448d1c4e5ebf2ddb4917c0633c201db (Closed)
Patch Set: Mark one more test as potentially timing out Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/resources/reactions.js
diff --git a/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/resources/reactions.js b/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/resources/reactions.js
index c260dc4f3f861a4bd4d939935ff85f9cc9b898c5..1d6c48e868b8b5314f1ead999e061fff3b1e3150 100644
--- a/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/resources/reactions.js
+++ b/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/resources/reactions.js
@@ -39,13 +39,47 @@ function testNodeDisconnector(testFunction, name) {
assert_array_equals(element.takeLog().types(), ['constructed']);
container.appendChild(instance);
assert_array_equals(element.takeLog().types(), ['connected']);
- testFunction(instance);
+ testFunction(instance, window);
assert_array_equals(element.takeLog().types(), ['disconnected']);
}, name + ' must enqueue a disconnected reaction');
container.parentNode.removeChild(container);
}
+function testInsertingMarkup(testFunction, name) {
+ let container = document.createElement('div');
+ container.appendChild(document.createElement('div'));
+ document.body.appendChild(container);
+
+ test(function () {
+ var element = define_new_custom_element();
+ testFunction(container, `<${element.name}></${element.name}>`);
+ assert_array_equals(element.takeLog().types(), ['constructed', 'connected']);
+ }, name + ' must enqueue a connected reaction for a newly constructed custom element');
+
+ test(function () {
+ var element = define_new_custom_element(['title']);
+ testFunction(container, `<${element.name} id="hello" title="hi"></${element.name}>`);
+ var logEntries = element.takeLog();
+ assert_array_equals(logEntries.types(), ['constructed', 'attributeChanged', 'connected']);
+ assert_attribute_log_entry(logEntries[1], {name: 'title', oldValue: null, newValue: 'hi', namespace: null});
+ }, name + ' must enqueue a attributeChanged reaction for a newly constructed custom element');
+
+ container.parentNode.removeChild(container);
+}
+
+function testParsingMarkup(testFunction, name) {
+ test(function () {
+ var element = define_new_custom_element(['id']);
+ assert_array_equals(element.takeLog().types(), []);
+ var instance = testFunction(document, `<${element.name} id="hello" class="foo"></${element.name}>`);
+ assert_equals(Object.getPrototypeOf(instance.querySelector(element.name)), element.class);
+ var logEntries = element.takeLog();
+ assert_array_equals(logEntries.types(), ['constructed', 'attributeChanged']);
+ assert_attribute_log_entry(logEntries[1], {name: 'id', oldValue: null, newValue: 'hello', namespace: null});
+ }, name + ' must construct a custom element');
+}
+
function testCloner(testFunction, name) {
let container = document.createElement('div');
container.appendChild(document.createElement('div'));
@@ -92,7 +126,7 @@ function testCloner(testFunction, name) {
}, name + ' must enqueue an attributeChanged reaction when cloning an element only for observed attributes');
}
-function testReflectAttribute(jsAttributeName, contentAttributeName, validValue1, validValue2, name) {
+function testReflectAttributeWithContentValues(jsAttributeName, contentAttributeName, validValue1, contentValue1, validValue2, contentValue2, name) {
test(function () {
var element = define_new_custom_element([contentAttributeName]);
var instance = document.createElement(element.name);
@@ -100,7 +134,8 @@ function testReflectAttribute(jsAttributeName, contentAttributeName, validValue1
instance[jsAttributeName] = validValue1;
var logEntries = element.takeLog();
assert_array_equals(logEntries.types(), ['attributeChanged']);
- assert_attribute_log_entry(logEntries.last(), {name: contentAttributeName, oldValue: null, newValue: validValue1, namespace: null});
+
+ assert_attribute_log_entry(logEntries.last(), {name: contentAttributeName, oldValue: null, newValue: contentValue1, namespace: null});
}, name + ' must enqueue an attributeChanged reaction when adding ' + contentAttributeName + ' content attribute');
test(function () {
@@ -111,10 +146,18 @@ function testReflectAttribute(jsAttributeName, contentAttributeName, validValue1
instance[jsAttributeName] = validValue2;
var logEntries = element.takeLog();
assert_array_equals(logEntries.types(), ['attributeChanged']);
- assert_attribute_log_entry(logEntries.last(), {name: contentAttributeName, oldValue: validValue1, newValue: validValue2, namespace: null});
+ assert_attribute_log_entry(logEntries.last(), {name: contentAttributeName, oldValue: contentValue1, newValue: contentValue2, namespace: null});
}, name + ' must enqueue an attributeChanged reaction when replacing an existing attribute');
}
+function testReflectAttribute(jsAttributeName, contentAttributeName, validValue1, validValue2, name) {
+ testReflectAttributeWithContentValues(jsAttributeName, contentAttributeName, validValue1, validValue1, validValue2, validValue2, name);
+}
+
+function testReflectBooleanAttribute(jsAttributeName, contentAttributeName, name) {
+ testReflectAttributeWithContentValues(jsAttributeName, contentAttributeName, true, '', false, null, name);
+}
+
function testAttributeAdder(testFunction, name) {
test(function () {
var element = define_new_custom_element(['id']);
@@ -177,14 +220,16 @@ function testAttributeMutator(testFunction, name) {
}, name + ' must not enqueue an attributeChanged reaction when replacing an existing unobserved attribute');
}
-function testAttributeRemover(testFunction, name) {
- test(function () {
- var element = define_new_custom_element(['title']);
- var instance = document.createElement(element.name);
- assert_array_equals(element.takeLog().types(), ['constructed']);
- testFunction(instance, 'title');
- assert_array_equals(element.takeLog().types(), []);
- }, name + ' must not enqueue an attributeChanged reaction when removing an attribute that does not exist');
+function testAttributeRemover(testFunction, name, options) {
+ if (options && !options.onlyExistingAttribute) {
+ test(function () {
+ var element = define_new_custom_element(['title']);
+ var instance = document.createElement(element.name);
+ assert_array_equals(element.takeLog().types(), ['constructed']);
+ testFunction(instance, 'title');
+ assert_array_equals(element.takeLog().types(), []);
+ }, name + ' must not enqueue an attributeChanged reaction when removing an attribute that does not exist');
+ }
test(function () {
var element = define_new_custom_element([]);

Powered by Google App Engine
This is Rietveld 408576698