mash: Move directly linked NewWindowDelegate to mojom::NewWindowClient.

mash: Move directly linked NewWindowDelegate to mojom::NewWindowClient.

Previously, NewWindowDelegate was an interface that chrome implemented
and injected into ash through the shell delegate. Now chrome exports its
implementation of mojom::NewWindowClient.

BUG=631836
Committed: https://crrev.com/3404382dde0b1a5a2911d476252b6a823dca3e65
Cr-Commit-Position: refs/heads/master@{#427834}

[Elliot Glaysher, 2016-10-19 21:11:21]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 21:12:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 21:19:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 21:19:23]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Elliot Glaysher, 2016-10-19 21:25:13]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 21:26:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 22:30:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 22:30:14]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Elliot Glaysher, 2016-10-19 23:05:03]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 23:05:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 02:17:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 02:17:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Elliot Glaysher, 2016-10-20 18:17:50]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 18:18:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 18:21:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 18:21:17]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Elliot Glaysher, 2016-10-20 19:33:23]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 19:33:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 20:58:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 20:58:34]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2016-10-20 21:00:16]

Description was changed from

==========
mash: Move directly linked NewWindowDelegate to mojom::NewWindowClient.

Previously, NewWindowDelegate was an interface that chrome implemented
and injected into ash through the shell delegate. Now chrome exports its
implementation of mojom::NewWindowClient.

todo: need to get the double window bug fixed here; this is just for try runs
right now.

BUG=
==========

to

==========
mash: Move directly linked NewWindowDelegate to mojom::NewWindowClient.

Previously, NewWindowDelegate was an interface that chrome implemented
and injected into ash through the shell delegate. Now chrome exports its
implementation of mojom::NewWindowClient.

BUG=631836
==========

[Elliot Glaysher, 2016-10-20 21:42:36]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 21:43:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 22:02:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 22:02:52]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Elliot Glaysher, 2016-10-20 22:05:33]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 22:06:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 23:30:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 23:30:24]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2016-10-21 18:09:58]

erg@chromium.org changed reviewers:
+ jamescook@chromium.org

[Elliot Glaysher, 2016-10-21 18:10:00]

This is functionally complete. I'm not sure about the naming though:
NewWindowClientRemote might not be the best name for a local object which
implements a mojo interface to proxy to a remote mojo interface?

[Elliot Glaysher, 2016-10-21 20:31:01]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 20:32:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 20:35:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 20:35:27]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Elliot Glaysher, 2016-10-21 21:38:49]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 21:39:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-10-21 22:22:31]

LGTM with nits. Nice patch - always good to see net negative lines of code.

https://codereview.chromium.org/2434463004/diff/160001/ash/common/new_window_...
File ash/common/new_window_client_remote.cc (right):

https://codereview.chromium.org/2434463004/diff/160001/ash/common/new_window_...
ash/common/new_window_client_remote.cc:14: : connector_(connector) {}
DCHECK connector_ ?

https://codereview.chromium.org/2434463004/diff/160001/ash/common/new_window_...
File ash/common/new_window_client_remote.h (right):

https://codereview.chromium.org/2434463004/diff/160001/ash/common/new_window_...
ash/common/new_window_client_remote.h:21:
NewWindowClientRemote(service_manager::Connector* connector);
nit: explicit

https://codereview.chromium.org/2434463004/diff/160001/ash/common/test/wm_she...
File ash/common/test/wm_shell_test_api.cc (right):

https://codereview.chromium.org/2434463004/diff/160001/ash/common/test/wm_she...
ash/common/test/wm_shell_test_api.cc:24:
WmShell::Get()->SetNewWindowClient(std::move(client));
Maybe directly access the member variable and get rid of the SetNewWindowClient
method entirely

https://codereview.chromium.org/2434463004/diff/160001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2434463004/diff/160001/ash/common/wm_shell.h#...
ash/common/wm_shell.h:466: void SetNewWindowClient(
or rename this ForTesting?

https://codereview.chromium.org/2434463004/diff/160001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/chrome_new_window_client.cc (left):

https://codereview.chromium.org/2434463004/diff/160001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/chrome_new_window_client.cc:8: #include
"ash/wm/window_util.h"
Nice that you were able to get rid of this dependency.

https://codereview.chromium.org/2434463004/diff/160001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/chrome_new_window_client.h (right):

https://codereview.chromium.org/2434463004/diff/160001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/chrome_new_window_client.h:11: #include
"base/compiler_specific.h"
optional nit: delete this while you're here?

https://codereview.chromium.org/2434463004/diff/160001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/chrome_new_window_client_browsertest.cc (right):

https://codereview.chromium.org/2434463004/diff/160001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/chrome_new_window_client_browsertest.cc:24: typedef
InProcessBrowserTest ChromeNewWindowClientBrowserTest;
nit: if you're touching it anyway, using foo = bar;

https://codereview.chromium.org/2434463004/diff/160001/chrome/browser/ui/brow...
File chrome/browser/ui/browser_commands.cc (right):

https://codereview.chromium.org/2434463004/diff/160001/chrome/browser/ui/brow...
chrome/browser/ui/browser_commands.cc:1073: service_manager::Connector*
connector =
nit: Maybe comment pointing out that under mash the task viewer is a separate
application? And maybe why that's a good idea?

https://codereview.chromium.org/2434463004/diff/160002/ash/common/new_window_...
File ash/common/new_window_client_remote.h (right):

https://codereview.chromium.org/2434463004/diff/160002/ash/common/new_window_...
ash/common/new_window_client_remote.h:19: class NewWindowClientRemote : public
mojom::NewWindowClient {
I'm OK with NewWindowClient, NewWindowClientImpl, or even NewWindowClientProxy.

[Elliot Glaysher, 2016-10-21 22:42:17]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 22:42:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2016-10-21 22:45:54]

erg@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[Elliot Glaysher, 2016-10-21 22:45:56]

+sky: chrome review
+tsepez: new mojom review

https://codereview.chromium.org/2434463004/diff/160001/ash/common/new_window_...
File ash/common/new_window_client_remote.cc (right):

https://codereview.chromium.org/2434463004/diff/160001/ash/common/new_window_...
ash/common/new_window_client_remote.cc:14: : connector_(connector) {}
On 2016/10/21 22:22:30, James Cook wrote:
> DCHECK connector_ ?

Done.

https://codereview.chromium.org/2434463004/diff/160001/ash/common/new_window_...
File ash/common/new_window_client_remote.h (right):

https://codereview.chromium.org/2434463004/diff/160001/ash/common/new_window_...
ash/common/new_window_client_remote.h:21:
NewWindowClientRemote(service_manager::Connector* connector);
On 2016/10/21 22:22:30, James Cook wrote:
> nit: explicit

Done.

https://codereview.chromium.org/2434463004/diff/160001/ash/common/test/wm_she...
File ash/common/test/wm_shell_test_api.cc (right):

https://codereview.chromium.org/2434463004/diff/160001/ash/common/test/wm_she...
ash/common/test/wm_shell_test_api.cc:24:
WmShell::Get()->SetNewWindowClient(std::move(client));
On 2016/10/21 22:22:30, James Cook wrote:
> Maybe directly access the member variable and get rid of the
SetNewWindowClient
> method entirely

Done.

https://codereview.chromium.org/2434463004/diff/160001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2434463004/diff/160001/ash/common/wm_shell.h#...
ash/common/wm_shell.h:466: void SetNewWindowClient(
On 2016/10/21 22:22:30, James Cook wrote:
> or rename this ForTesting?

(Deleted).

https://codereview.chromium.org/2434463004/diff/160001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/chrome_new_window_client.cc (left):

https://codereview.chromium.org/2434463004/diff/160001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/chrome_new_window_client.cc:8: #include
"ash/wm/window_util.h"
On 2016/10/21 22:22:30, James Cook wrote:
> Nice that you were able to get rid of this dependency.

Acknowledged.

https://codereview.chromium.org/2434463004/diff/160001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/chrome_new_window_client.h (right):

https://codereview.chromium.org/2434463004/diff/160001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/chrome_new_window_client.h:11: #include
"base/compiler_specific.h"
On 2016/10/21 22:22:30, James Cook wrote:
> optional nit: delete this while you're here?

Done.

https://codereview.chromium.org/2434463004/diff/160001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/chrome_new_window_client_browsertest.cc (right):

https://codereview.chromium.org/2434463004/diff/160001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/chrome_new_window_client_browsertest.cc:24: typedef
InProcessBrowserTest ChromeNewWindowClientBrowserTest;
On 2016/10/21 22:22:30, James Cook wrote:
> nit: if you're touching it anyway, using foo = bar;

Done.

https://codereview.chromium.org/2434463004/diff/160001/chrome/browser/ui/brow...
File chrome/browser/ui/browser_commands.cc (right):

https://codereview.chromium.org/2434463004/diff/160001/chrome/browser/ui/brow...
chrome/browser/ui/browser_commands.cc:1073: service_manager::Connector*
connector =
On 2016/10/21 22:22:31, James Cook wrote:
> nit: Maybe comment pointing out that under mash the task viewer is a separate
> application? And maybe why that's a good idea?

Done.

https://codereview.chromium.org/2434463004/diff/160002/ash/common/new_window_...
File ash/common/new_window_client_remote.h (right):

https://codereview.chromium.org/2434463004/diff/160002/ash/common/new_window_...
ash/common/new_window_client_remote.h:19: class NewWindowClientRemote : public
mojom::NewWindowClient {
On 2016/10/21 22:22:31, James Cook wrote:
> I'm OK with NewWindowClient, NewWindowClientImpl, or even
NewWindowClientProxy.

NewWindowClientProxy it is. (I want to have something in the name referencing
that it will be contacting a remote object.)

[Tom Sepez, 2016-10-21 23:00:21]

mojom LGTM

[sky, 2016-10-21 23:26:00]

LGTM assuming you change to use Chrome's task manager. If you feel strongly we
should use the mash one, lets talk about it.

https://codereview.chromium.org/2434463004/diff/190001/chrome/browser/chromeo...
File chrome/browser/chromeos/accessibility/sticky_keys_browsertest.cc (right):

https://codereview.chromium.org/2434463004/diff/190001/chrome/browser/chromeo...
chrome/browser/chromeos/accessibility/sticky_keys_browsertest.cc:40: int
new_tab_action_count() { return new_tab_action_count_; }
const

https://codereview.chromium.org/2434463004/diff/190001/chrome/browser/ui/brow...
File chrome/browser/ui/browser_commands.cc (right):

https://codereview.chromium.org/2434463004/diff/190001/chrome/browser/ui/brow...
chrome/browser/ui/browser_commands.cc:1072: if (chrome::IsRunningInMash()) {
The mash task viewer doesn't convey everything the chrome one does. I think we
should continue using the chrome one.

[commit-bot: I haz the power, 2016-10-21 23:49:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 23:49:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Elliot Glaysher, 2016-10-25 18:06:50]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 18:07:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 19:09:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 19:09:30]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2016-10-25 19:21:07]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 19:21:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 19:23:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 19:23:59]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Elliot Glaysher, 2016-10-25 20:02:20]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 20:02:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2016-10-25 20:05:46]

erg@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Elliot Glaysher, 2016-10-25 20:05:47]

stevenjb: chrome/browser/ui/webui/options/chromeos/
yusukes: components/arc/

These changes are just minor interface changes.

[stevenjb, 2016-10-25 20:13:59]

c/b/ui/webui lgtm

[Elliot Glaysher, 2016-10-25 21:09:53]

erg@chromium.org changed reviewers:
+ yusukes@chromium.org

[Elliot Glaysher, 2016-10-25 21:09:54]

yusukes: components/arc/ (really added this time)

These changes are just minor interface changes.

[commit-bot: I haz the power, 2016-10-25 21:33:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 21:33:10]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Elliot Glaysher, 2016-10-25 23:30:50]

https://codereview.chromium.org/2434463004/diff/190001/chrome/browser/chromeo...
File chrome/browser/chromeos/accessibility/sticky_keys_browsertest.cc (right):

https://codereview.chromium.org/2434463004/diff/190001/chrome/browser/chromeo...
chrome/browser/chromeos/accessibility/sticky_keys_browsertest.cc:40: int
new_tab_action_count() { return new_tab_action_count_; }
On 2016/10/21 23:26:00, sky wrote:
> const

Done.

https://codereview.chromium.org/2434463004/diff/190001/chrome/browser/ui/brow...
File chrome/browser/ui/browser_commands.cc (right):

https://codereview.chromium.org/2434463004/diff/190001/chrome/browser/ui/brow...
chrome/browser/ui/browser_commands.cc:1072: if (chrome::IsRunningInMash()) {
On 2016/10/21 23:26:00, sky wrote:
> The mash task viewer doesn't convey everything the chrome one does. I think we
> should continue using the chrome one.

Moved back to chrome's task viewer for now.

[sky, 2016-10-25 23:51:23]

LGTM

[Yusuke Sato, 2016-10-26 03:26:58]

arc/ lgtm

[Elliot Glaysher, 2016-10-26 19:22:53]

The CQ bit was checked by erg@chromium.org

[Elliot Glaysher, 2016-10-26 19:22:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, tsepez@chromium.org, yusukes@chromium.org,
sky@chromium.org, stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2434463004/#ps270001
(title: "Rebase to ToT")

[commit-bot: I haz the power, 2016-10-26 19:23:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 19:33:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 19:33:57]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Elliot Glaysher, 2016-10-26 19:52:43]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2016-10-26 19:53:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 20:03:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 20:03:20]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Elliot Glaysher, 2016-10-26 20:11:54]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2016-10-26 20:12:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 20:23:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 20:23:38]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Elliot Glaysher, 2016-10-26 20:59:49]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2016-10-26 21:00:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 21:58:45]

Committed patchset #15 (id:270001)

[commit-bot: I haz the power, 2016-10-26 22:03:29]

Description was changed from

==========
mash: Move directly linked NewWindowDelegate to mojom::NewWindowClient.

Previously, NewWindowDelegate was an interface that chrome implemented
and injected into ash through the shell delegate. Now chrome exports its
implementation of mojom::NewWindowClient.

BUG=631836
==========

to

==========
mash: Move directly linked NewWindowDelegate to mojom::NewWindowClient.

Previously, NewWindowDelegate was an interface that chrome implemented
and injected into ash through the shell delegate. Now chrome exports its
implementation of mojom::NewWindowClient.

BUG=631836

Committed: https://crrev.com/3404382dde0b1a5a2911d476252b6a823dca3e65
Cr-Commit-Position: refs/heads/master@{#427834}
==========

[commit-bot: I haz the power, 2016-10-26 22:03:31]

Patchset 15 (id:??) landed as
https://crrev.com/3404382dde0b1a5a2911d476252b6a823dca3e65
Cr-Commit-Position: refs/heads/master@{#427834}