Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 2452783002: mash: remove AcceleratorRegistrar. (Closed)

Created:
4 years, 1 month ago by Elliot Glaysher
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: remove AcceleratorRegistrar. As requested after the remove app_driver patch, we can now remove the entire AcceleratorRegistrar concept now that accelerators are hooked up properly in ash. BUG=631836 Committed: https://crrev.com/0ba8dcf8d202abbc5fbec456dc0749d3a35de6cc Cr-Commit-Position: refs/heads/master@{#427872}

Patch Set 1 #

Patch Set 2 : Rebase to tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -552 lines) Patch
M ash/mus/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D ash/mus/accelerators/accelerator_registrar_impl.h View 1 chunk +0 lines, -99 lines 0 comments Download
D ash/mus/accelerators/accelerator_registrar_impl.cc View 1 chunk +0 lines, -263 lines 0 comments Download
D ash/mus/accelerators/accelerator_registrar_unittest.cc View 1 chunk +0 lines, -120 lines 0 comments Download
M ash/mus/window_manager_application.h View 6 chunks +0 lines, -11 lines 0 comments Download
M ash/mus/window_manager_application.cc View 5 chunks +0 lines, -33 lines 0 comments Download
M services/ui/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D services/ui/public/interfaces/accelerator_registrar.mojom View 1 chunk +0 lines, -22 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (12 generated)
Elliot Glaysher
This deletes all of accelerator_registrar.mojom implementations, as asked for in https://codereview.chromium.org/2428173002/
4 years, 1 month ago (2016-10-25 22:29:37 UTC) #4
sky
LGTM
4 years, 1 month ago (2016-10-25 23:03:10 UTC) #7
Elliot Glaysher
+tsepez for deleted mojom file
4 years, 1 month ago (2016-10-26 22:07:38 UTC) #9
Tom Sepez
RS LGTM
4 years, 1 month ago (2016-10-26 22:33:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452783002/20001
4 years, 1 month ago (2016-10-26 22:34:26 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 23:25:14 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 23:28:44 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0ba8dcf8d202abbc5fbec456dc0749d3a35de6cc
Cr-Commit-Position: refs/heads/master@{#427872}

Powered by Google App Engine
This is Rietveld 408576698