Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2428173002: mash: Remove app_driver. (Closed)

Created:
4 years, 2 months ago by Elliot Glaysher
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Remove app_driver. As part of actually implementing a mus version of the NewWindowDelegate, accelerators need to be routed through ash instead of through temporary shim code. Without AppDriver, the keyboard shortcuts are handled by ash's NewWindowDelegate, of which implementing is the next patch. BUG=631836 Committed: https://crrev.com/fafcda5411844c3a723b0a5be575f77acf8d731d Cr-Commit-Position: refs/heads/master@{#427761}

Patch Set 1 #

Patch Set 2 : Remove unused constant/code. #

Patch Set 3 : Add OWNERS to the mojom directory. #

Patch Set 4 : Rebase to tot #

Patch Set 5 : Rebase to tot #

Patch Set 6 : Rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -293 lines) Patch
M chrome/app/mash/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_interface_factory.cc View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
D mash/app_driver/BUILD.gn View 1 chunk +0 lines, -56 lines 0 comments Download
D mash/app_driver/app_driver.h View 1 2 3 4 1 chunk +0 lines, -53 lines 0 comments Download
D mash/app_driver/app_driver.cc View 1 2 3 4 1 chunk +0 lines, -139 lines 0 comments Download
D mash/app_driver/main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D mash/app_driver/manifest.json View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M mash/package/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/package/mash_packaged_service.cc View 1 2 3 4 2 chunks +0 lines, -3 lines 0 comments Download
A + mash/public/interfaces/OWNERS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M mash/public/interfaces/launchable.mojom View 1 1 chunk +1 line, -2 lines 0 comments Download
M mash/session/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/session/session.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M mash/session/session.cc View 1 2 3 4 2 chunks +0 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (18 generated)
Elliot Glaysher
This patch removes the current app driver code which is handling accelerators. Enough of ash ...
4 years, 2 months ago (2016-10-20 21:20:32 UTC) #12
sky
Yay! LGTM After this lands you should be able to get rid of services/ui/public/interfaces/accelerator_registrar.mojom too.
4 years, 2 months ago (2016-10-20 22:41:57 UTC) #13
Tom Sepez
lgtm
4 years, 2 months ago (2016-10-20 23:00:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428173002/100001
4 years, 1 month ago (2016-10-26 17:39:52 UTC) #21
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 1 month ago (2016-10-26 18:48:04 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 18:53:39 UTC) #24
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/fafcda5411844c3a723b0a5be575f77acf8d731d
Cr-Commit-Position: refs/heads/master@{#427761}

Powered by Google App Engine
This is Rietveld 408576698