Merge more Kernel infrastructure from kernel_sdk SDK fork.

Merge more Kernel infrastructure from kernel_sdk SDK fork.

- bring patched SDK generation scripts and VM patch tweaks that allow VM patch files to be parsed by analyzer front-end;
  Patched SDK is an SDK with all VM patches spliced into it. Kernel compiler is based on the analyzer front-end which does
  not have any patch files support/model so for it to produce Kernel files that match VM we need to generate a such patched SDKs.

- bring test script modifications that allow to test Kernel pipeline

BUG=
R=asiva@google.com, kmillikin@google.com, whesse@google.com, zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/2fed1c39053eec122fa5bfec9a123ca2c5b80500

[Vyacheslav Egorov (Google), 2016-10-20 16:49:37]

vegorov@google.com changed reviewers:
+ asiva@google.com, kmillikin@google.com, whesse@google.com

[Vyacheslav Egorov (Google), 2016-10-20 16:49:38]

PTAL

(this depends on https://chromiumcodereview.appspot.com/2435013003/ which is in
process of being landed)

[Kevin Millikin (Google), 2016-10-21 09:10:58]

LGTM.

Ultimately when the analyzer can handle patch files, we should be able to have
imports in the individual patch files.  So we should keep in mind that we've
artificially moved them around for now.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/kernel.status
File tests/kernel/kernel.status (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/kernel.status#...
tests/kernel/kernel.status:1: unsorted/invocation_errors_test: RuntimeError
I guess even the test status files should have copyright headers.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/break...
File tests/kernel/unsorted/breakable_statement_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/break...
tests/kernel/unsorted/breakable_statement_test.dart:1: import 'expect.dart';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/const...
File tests/kernel/unsorted/constant_expressions_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/const...
tests/kernel/unsorted/constant_expressions_test.dart:1: import 'expect.dart';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/expec...
File tests/kernel/unsorted/expect.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/expec...
tests/kernel/unsorted/expect.dart:1: import 'dart:io' as io;
Copyright header.  We can actually use expect in these tests now, perhaps file
an issue to change it?

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/facto...
File tests/kernel/unsorted/factory_regression_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/facto...
tests/kernel/unsorted/factory_regression_test.dart:1: import 'dart:typed_data';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/gette...
File tests/kernel/unsorted/getters_and_setters_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/gette...
tests/kernel/unsorted/getters_and_setters_test.dart:1: import 'expect.dart';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/globa...
File tests/kernel/unsorted/global_field_initializer_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/globa...
tests/kernel/unsorted/global_field_initializer_test.dart:1: import
'expect.dart';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/globa...
File tests/kernel/unsorted/global_function_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/globa...
tests/kernel/unsorted/global_function_test.dart:1: main() {
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/insta...
File tests/kernel/unsorted/instance_getters_and_setters_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/insta...
tests/kernel/unsorted/instance_getters_and_setters_test.dart:1: import
'expect.dart';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/klass...
File tests/kernel/unsorted/klass_field_initializer_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/klass...
tests/kernel/unsorted/klass_field_initializer_test.dart:1: import 'expect.dart';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/klass...
File tests/kernel/unsorted/klass_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/klass...
tests/kernel/unsorted/klass_test.dart:1: class A {
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/let_t...
File tests/kernel/unsorted/let_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/let_t...
tests/kernel/unsorted/let_test.dart:1: import 'expect.dart';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/mapli...
File tests/kernel/unsorted/mapliteral_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/mapli...
tests/kernel/unsorted/mapliteral_test.dart:1: import 'expect.dart';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/mixin...
File tests/kernel/unsorted/mixin_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/mixin...
tests/kernel/unsorted/mixin_test.dart:1: import 'expect.dart';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/nulla...
File tests/kernel/unsorted/nullable_operator_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/nulla...
tests/kernel/unsorted/nullable_operator_test.dart:1: import 'expect.dart';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/rethr...
File tests/kernel/unsorted/rethrow_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/rethr...
tests/kernel/unsorted/rethrow_test.dart:1: import 'expect.dart';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/strin...
File tests/kernel/unsorted/string_buffer_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/strin...
tests/kernel/unsorted/string_buffer_test.dart:1: 
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/strin...
File tests/kernel/unsorted/string_concatenation_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/strin...
tests/kernel/unsorted/string_concatenation_test.dart:1: import 'expect.dart';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/super...
File tests/kernel/unsorted/super_mixin_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/super...
tests/kernel/unsorted/super_mixin_test.dart:1: import 'expect.dart';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/super...
File tests/kernel/unsorted/super_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/super...
tests/kernel/unsorted/super_test.dart:1: import 'expect.dart';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/super...
File tests/kernel/unsorted/superclass_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/super...
tests/kernel/unsorted/superclass_test.dart:1: import 'expect.dart';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/symbo...
File tests/kernel/unsorted/symbol_literal_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/symbo...
tests/kernel/unsorted/symbol_literal_test.dart:1: import 'expect.dart';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/this_...
File tests/kernel/unsorted/this_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/this_...
tests/kernel/unsorted/this_test.dart:1: import 'expect.dart';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/throw...
File tests/kernel/unsorted/throw_try_catch_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/throw...
tests/kernel/unsorted/throw_try_catch_test.dart:1: import 'expect.dart';
Copyright header.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/try_f...
File tests/kernel/unsorted/try_finally_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/try_f...
tests/kernel/unsorted/try_finally_test.dart:1: import 'expect.dart';
Copyright header.

[Bill Hesse, 2016-10-21 12:17:39]

lgtm

https://codereview.chromium.org/2434123003/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/2434123003/diff/1/DEPS#newcode578
DEPS:578: 'name': 'run_pub_get',
This adds a lot of complexity, I think, and so we want to get both copies of
kernel using the packages in pkg, third_party/pkg, and third_party/pkg_tested as
soon as possible, and drop this.  If not in this CL, then in a follow-up ASAP.

https://codereview.chromium.org/2434123003/diff/1/tools/testing/dart/test_opt...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tools/testing/dart/test_opt...
tools/testing/dart/test_options.dart:79: (only valid with dart_app runtime)''',
Can we expand this comment with the new compilers?

https://codereview.chromium.org/2434123003/diff/1/tools/testing/dart/test_run...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tools/testing/dart/test_run...
tools/testing/dart/test_runner.dart:252: environmentOverrides);
Override operator == to include useBatchMode?

[Vyacheslav Egorov (Google), 2016-10-21 13:37:24]

Description was changed from

==========
Merge more Kernel infrastructure from kernel_sdk SDK fork.

- bring over dependency on the Kernel package. For now we will have two
different copies of Kernel in the SDK: one used by dart2js in
third_party/pkg/kernel and one used for VM in third_party/kernel.

- bring patched SDK generation scripts and VM patch tweaks that allow VM patch
files to be parsed by analyzer front-end;
  Patched SDK is an SDK with all VM patches spliced into it. Kernel compiler is
based on the analyzer front-end which does
  not have any patch files support/model so for it to produce Kernel files that
match VM we need to generate a such patched SDKs.

- bring test script modifications that allow to test Kernel pipeline

BUG=
==========

to

==========
Merge more Kernel infrastructure from kernel_sdk SDK fork.

- bring patched SDK generation scripts and VM patch tweaks that allow VM patch
files to be parsed by analyzer front-end;
  Patched SDK is an SDK with all VM patches spliced into it. Kernel compiler is
based on the analyzer front-end which does
  not have any patch files support/model so for it to produce Kernel files that
match VM we need to generate a such patched SDKs.

- bring test script modifications that allow to test Kernel pipeline

BUG=
==========

[Vyacheslav Egorov (Google), 2016-10-21 13:39:44]

Please take another look. 

I removed additional copy of Kernel - that did not work as intended anyway. 

We will roll Kernel forward for the whole SDK in a separate CL (we need a patch
landed in it - https://chromereviews.googleplex.com/527977013/ before rolling).

https://codereview.chromium.org/2434123003/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/2434123003/diff/1/DEPS#newcode578
DEPS:578: 'name': 'run_pub_get',
On 2016/10/21 12:17:39, Bill Hesse wrote:
> This adds a lot of complexity, I think, and so we want to get both copies of
> kernel using the packages in pkg, third_party/pkg, and third_party/pkg_tested
as
> soon as possible, and drop this.  If not in this CL, then in a follow-up ASAP.

I killed this.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/kernel.status
File tests/kernel/kernel.status (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/kernel.status#...
tests/kernel/kernel.status:1: unsorted/invocation_errors_test: RuntimeError
On 2016/10/21 09:10:57, Kevin Millikin (Google) wrote:
> I guess even the test status files should have copyright headers.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/break...
File tests/kernel/unsorted/breakable_statement_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/break...
tests/kernel/unsorted/breakable_statement_test.dart:1: import 'expect.dart';
On 2016/10/21 09:10:57, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/expec...
File tests/kernel/unsorted/expect.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/expec...
tests/kernel/unsorted/expect.dart:1: import 'dart:io' as io;
On 2016/10/21 09:10:57, Kevin Millikin (Google) wrote:
> Copyright header.  We can actually use expect in these tests now, perhaps file
> an issue to change it?

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/gette...
File tests/kernel/unsorted/getters_and_setters_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/gette...
tests/kernel/unsorted/getters_and_setters_test.dart:1: import 'expect.dart';
On 2016/10/21 09:10:57, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/globa...
File tests/kernel/unsorted/global_field_initializer_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/globa...
tests/kernel/unsorted/global_field_initializer_test.dart:1: import
'expect.dart';
On 2016/10/21 09:10:57, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/globa...
File tests/kernel/unsorted/global_function_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/globa...
tests/kernel/unsorted/global_function_test.dart:1: main() {
On 2016/10/21 09:10:57, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/insta...
File tests/kernel/unsorted/instance_getters_and_setters_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/insta...
tests/kernel/unsorted/instance_getters_and_setters_test.dart:1: import
'expect.dart';
On 2016/10/21 09:10:57, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/klass...
File tests/kernel/unsorted/klass_field_initializer_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/klass...
tests/kernel/unsorted/klass_field_initializer_test.dart:1: import 'expect.dart';
On 2016/10/21 09:10:57, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/klass...
File tests/kernel/unsorted/klass_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/klass...
tests/kernel/unsorted/klass_test.dart:1: class A {
On 2016/10/21 09:10:57, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/let_t...
File tests/kernel/unsorted/let_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/let_t...
tests/kernel/unsorted/let_test.dart:1: import 'expect.dart';
On 2016/10/21 09:10:57, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/mapli...
File tests/kernel/unsorted/mapliteral_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/mapli...
tests/kernel/unsorted/mapliteral_test.dart:1: import 'expect.dart';
On 2016/10/21 09:10:57, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/mixin...
File tests/kernel/unsorted/mixin_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/mixin...
tests/kernel/unsorted/mixin_test.dart:1: import 'expect.dart';
On 2016/10/21 09:10:57, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/nulla...
File tests/kernel/unsorted/nullable_operator_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/nulla...
tests/kernel/unsorted/nullable_operator_test.dart:1: import 'expect.dart';
On 2016/10/21 09:10:58, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/rethr...
File tests/kernel/unsorted/rethrow_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/rethr...
tests/kernel/unsorted/rethrow_test.dart:1: import 'expect.dart';
On 2016/10/21 09:10:58, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/strin...
File tests/kernel/unsorted/string_buffer_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/strin...
tests/kernel/unsorted/string_buffer_test.dart:1: 
On 2016/10/21 09:10:58, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/strin...
File tests/kernel/unsorted/string_concatenation_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/strin...
tests/kernel/unsorted/string_concatenation_test.dart:1: import 'expect.dart';
On 2016/10/21 09:10:58, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/super...
File tests/kernel/unsorted/super_mixin_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/super...
tests/kernel/unsorted/super_mixin_test.dart:1: import 'expect.dart';
On 2016/10/21 09:10:58, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/super...
File tests/kernel/unsorted/super_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/super...
tests/kernel/unsorted/super_test.dart:1: import 'expect.dart';
On 2016/10/21 09:10:58, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/super...
File tests/kernel/unsorted/superclass_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/super...
tests/kernel/unsorted/superclass_test.dart:1: import 'expect.dart';
On 2016/10/21 09:10:58, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/symbo...
File tests/kernel/unsorted/symbol_literal_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/symbo...
tests/kernel/unsorted/symbol_literal_test.dart:1: import 'expect.dart';
On 2016/10/21 09:10:58, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/this_...
File tests/kernel/unsorted/this_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/this_...
tests/kernel/unsorted/this_test.dart:1: import 'expect.dart';
On 2016/10/21 09:10:58, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/throw...
File tests/kernel/unsorted/throw_try_catch_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/throw...
tests/kernel/unsorted/throw_try_catch_test.dart:1: import 'expect.dart';
On 2016/10/21 09:10:58, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/try_f...
File tests/kernel/unsorted/try_finally_test.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tests/kernel/unsorted/try_f...
tests/kernel/unsorted/try_finally_test.dart:1: import 'expect.dart';
On 2016/10/21 09:10:58, Kevin Millikin (Google) wrote:
> Copyright header.

Done.

https://codereview.chromium.org/2434123003/diff/1/tools/testing/dart/test_opt...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tools/testing/dart/test_opt...
tools/testing/dart/test_options.dart:79: (only valid with dart_app runtime)''',
On 2016/10/21 12:17:39, Bill Hesse wrote:
> Can we expand this comment with the new compilers?

Done.

https://codereview.chromium.org/2434123003/diff/1/tools/testing/dart/test_run...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/2434123003/diff/1/tools/testing/dart/test_run...
tools/testing/dart/test_runner.dart:252: environmentOverrides);
On 2016/10/21 12:17:39, Bill Hesse wrote:
> Override operator == to include useBatchMode?

I removed this class because it is not used anymore.

[Florian Schneider, 2016-10-21 15:36:08]

fschneider@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-10-21 15:36:09]

https://codereview.chromium.org/2434123003/diff/20001/runtime/bin/nativewrapp...
File runtime/bin/nativewrappers.dart (right):

https://codereview.chromium.org/2434123003/diff/20001/runtime/bin/nativewrapp...
runtime/bin/nativewrappers.dart:7: class NativeFieldWrapperClass1 extends Object
{}
Are these now duplicated (in Library::InitNativeWrappersLibrary) and declared
here? This should be fixed before landing.

https://codereview.chromium.org/2434123003/diff/20001/sdk/lib/internal/intern...
File sdk/lib/internal/internal.dart (right):

https://codereview.chromium.org/2434123003/diff/20001/sdk/lib/internal/intern...
sdk/lib/internal/internal.dart:68: class ExternalName {
Where is this class used?

[Vyacheslav Egorov (Google), 2016-10-21 15:55:32]

https://codereview.chromium.org/2434123003/diff/20001/runtime/bin/nativewrapp...
File runtime/bin/nativewrappers.dart (right):

https://codereview.chromium.org/2434123003/diff/20001/runtime/bin/nativewrapp...
runtime/bin/nativewrappers.dart:7: class NativeFieldWrapperClass1 extends Object
{}
On 2016/10/21 15:36:09, Florian Schneider wrote:
> Are these now duplicated (in Library::InitNativeWrappersLibrary) and declared
> here? This should be fixed before landing.

This file is actually not included into the VM (see gypi files - they don't
mention it). Only used by analyzer.

https://codereview.chromium.org/2434123003/diff/20001/sdk/lib/internal/intern...
File sdk/lib/internal/internal.dart (right):

https://codereview.chromium.org/2434123003/diff/20001/sdk/lib/internal/intern...
sdk/lib/internal/internal.dart:68: class ExternalName {
On 2016/10/21 15:36:09, Florian Schneider wrote:
> Where is this class used?

It is used in the internals of Dart -> Kernel compiler. 

I removed it from here and moved it into patched_sdk generation script.

[Florian Schneider, 2016-10-21 17:16:02]

https://codereview.chromium.org/2434123003/diff/20001/runtime/bin/nativewrapp...
File runtime/bin/nativewrappers.dart (right):

https://codereview.chromium.org/2434123003/diff/20001/runtime/bin/nativewrapp...
runtime/bin/nativewrappers.dart:7: class NativeFieldWrapperClass1 extends Object
{}
On 2016/10/21 15:55:32, Vyacheslav Egorov (Google) wrote:
> On 2016/10/21 15:36:09, Florian Schneider wrote:
> > Are these now duplicated (in Library::InitNativeWrappersLibrary) and
declared
> > here? This should be fixed before landing.
> 
> This file is actually not included into the VM (see gypi files - they don't
> mention it). Only used by analyzer.

Ok, didn't see that. Maybe add a comment about this library just mirroring the
VM-internal generated classes for the analyzer.

https://codereview.chromium.org/2434123003/diff/20001/sdk/lib/internal/intern...
File sdk/lib/internal/internal.dart (right):

https://codereview.chromium.org/2434123003/diff/20001/sdk/lib/internal/intern...
sdk/lib/internal/internal.dart:68: class ExternalName {
On 2016/10/21 15:55:32, Vyacheslav Egorov (Google) wrote:
> On 2016/10/21 15:36:09, Florian Schneider wrote:
> > Where is this class used?
> 
> It is used in the internals of Dart -> Kernel compiler. 
> 
> I removed it from here and moved it into patched_sdk generation script.

Thanks!

[siva, 2016-10-21 20:47:05]

asiva@google.com changed reviewers:
+ zra@google.com

[zra, 2016-10-21 21:34:43]

https://codereview.chromium.org/2434123003/diff/40001/dart.gyp
File dart.gyp (right):

https://codereview.chromium.org/2434123003/diff/40001/dart.gyp#newcode33
dart.gyp:33: 'runtime/dart-runtime.gyp:generate_patched_sdk#host',
Could you also please add this to the top-level BUILD.gn file? I would like to
keep these lined-up to make the transition smoother.

https://codereview.chromium.org/2434123003/diff/40001/dart.gyp#newcode45
dart.gyp:45: 'runtime/dart-runtime.gyp:generate_patched_sdk#host',
ditto.

https://codereview.chromium.org/2434123003/diff/40001/dart.gyp#newcode62
dart.gyp:62: 'runtime/dart-runtime.gyp:generate_patched_sdk#host',
ditto.

https://codereview.chromium.org/2434123003/diff/40001/runtime/vm/BUILD.gn
File runtime/vm/BUILD.gn (right):

https://codereview.chromium.org/2434123003/diff/40001/runtime/vm/BUILD.gn#new...
runtime/vm/BUILD.gn:63: deps = [":patched_sdk"]
Why is this dependency here, but not on the analogous target in the .gyp file?

https://codereview.chromium.org/2434123003/diff/40001/runtime/vm/BUILD.gn#new...
runtime/vm/BUILD.gn:63: deps = [":patched_sdk"]
Also, we tend to put 'deps' below 'configs'.

https://codereview.chromium.org/2434123003/diff/40001/runtime/vm/BUILD.gn#new...
runtime/vm/BUILD.gn:307: template("concatenate_patch") {
Optional: templates can use each other. Are there enough similarities between
this template and generate_library_source above that it would make sense to pull
out the common parts?

https://codereview.chromium.org/2434123003/diff/40001/runtime/vm/BUILD.gn#new...
runtime/vm/BUILD.gn:310: assert(defined(invoker.output), "Need a output in
$target_name")
an

https://codereview.chromium.org/2434123003/diff/40001/runtime/vm/BUILD.gn#new...
runtime/vm/BUILD.gn:339: vm_libraries = [ "async", "collection", "convert",
"core", "developer",
I would re-structure this as a template that takes a list of pairs as a
parameter, similar to 'generate_core_libraries' above, e.g.:

template("generate_patched_sdk") {
}

generate_patched_sdk("patched_sdk") {
  sources = [
    ["async", "lib"],
    ...,
    ["io", "bin"],
  ]
}

Then we can avoid the slightly un-idiomatic structure here of having templates
and actions inside a "group". (Typically, "groups" just have deps = [ ... ]")

https://codereview.chromium.org/2434123003/diff/40001/runtime/vm/BUILD.gn#new...
runtime/vm/BUILD.gn:345: # Concatenate vm library patches.
Then you can de-dup the invocation of concatenate_patch for vm_libraries and io
below.

https://codereview.chromium.org/2434123003/diff/40001/runtime/vm/BUILD.gn#new...
runtime/vm/BUILD.gn:383: "../../tools/list_files.py", ["dart\$",
"../../sdk/lib"], "list lines")
If you only want .dart files, then tools/list_dart_files.py should be a lot
faster.

[Vyacheslav Egorov (Google), 2016-10-24 13:35:10]

I have addressed latest comments.

(In reality BUILD.gn did not work at all the way it was written, sorry for that
:-/) 

Now things build with GN + ninja.

https://codereview.chromium.org/2434123003/diff/20001/runtime/bin/nativewrapp...
File runtime/bin/nativewrappers.dart (right):

https://codereview.chromium.org/2434123003/diff/20001/runtime/bin/nativewrapp...
runtime/bin/nativewrappers.dart:7: class NativeFieldWrapperClass1 extends Object
{}
On 2016/10/21 17:16:02, Florian Schneider wrote:
> On 2016/10/21 15:55:32, Vyacheslav Egorov (Google) wrote:
> > On 2016/10/21 15:36:09, Florian Schneider wrote:
> > > Are these now duplicated (in Library::InitNativeWrappersLibrary) and
> declared
> > > here? This should be fixed before landing.
> > 
> > This file is actually not included into the VM (see gypi files - they don't
> > mention it). Only used by analyzer.
> 
> Ok, didn't see that. Maybe add a comment about this library just mirroring the
> VM-internal generated classes for the analyzer.

Done.

https://codereview.chromium.org/2434123003/diff/40001/dart.gyp
File dart.gyp (right):

https://codereview.chromium.org/2434123003/diff/40001/dart.gyp#newcode33
dart.gyp:33: 'runtime/dart-runtime.gyp:generate_patched_sdk#host',
On 2016/10/21 21:34:43, zra wrote:
> Could you also please add this to the top-level BUILD.gn file? I would like to
> keep these lined-up to make the transition smoother.

Done.

https://codereview.chromium.org/2434123003/diff/40001/dart.gyp#newcode45
dart.gyp:45: 'runtime/dart-runtime.gyp:generate_patched_sdk#host',
On 2016/10/21 21:34:43, zra wrote:
> ditto.

Done.

https://codereview.chromium.org/2434123003/diff/40001/dart.gyp#newcode62
dart.gyp:62: 'runtime/dart-runtime.gyp:generate_patched_sdk#host',
On 2016/10/21 21:34:43, zra wrote:
> ditto.

Done.

https://codereview.chromium.org/2434123003/diff/40001/runtime/vm/BUILD.gn
File runtime/vm/BUILD.gn (right):

https://codereview.chromium.org/2434123003/diff/40001/runtime/vm/BUILD.gn#new...
runtime/vm/BUILD.gn:63: deps = [":patched_sdk"]
On 2016/10/21 21:34:43, zra wrote:
> Also, we tend to put 'deps' below 'configs'.

Done.

https://codereview.chromium.org/2434123003/diff/40001/runtime/vm/BUILD.gn#new...
runtime/vm/BUILD.gn:307: template("concatenate_patch") {
On 2016/10/21 21:34:43, zra wrote:
> Optional: templates can use each other. Are there enough similarities between
> this template and generate_library_source above that it would make sense to
pull
> out the common parts?

I have rewritten this code.

https://codereview.chromium.org/2434123003/diff/40001/runtime/vm/BUILD.gn#new...
runtime/vm/BUILD.gn:310: assert(defined(invoker.output), "Need a output in
$target_name")
On 2016/10/21 21:34:43, zra wrote:
> an

Done.

https://codereview.chromium.org/2434123003/diff/40001/runtime/vm/BUILD.gn#new...
runtime/vm/BUILD.gn:339: vm_libraries = [ "async", "collection", "convert",
"core", "developer",
On 2016/10/21 21:34:43, zra wrote:
> I would re-structure this as a template that takes a list of pairs as a
> parameter, similar to 'generate_core_libraries' above, e.g.:
> 
> template("generate_patched_sdk") {
> }
> 
> generate_patched_sdk("patched_sdk") {
>   sources = [
>     ["async", "lib"],
>     ...,
>     ["io", "bin"],
>   ]
> }
> 
> Then we can avoid the slightly un-idiomatic structure here of having templates
> and actions inside a "group". (Typically, "groups" just have deps = [ ... ]")

Done.

https://codereview.chromium.org/2434123003/diff/40001/runtime/vm/BUILD.gn#new...
runtime/vm/BUILD.gn:345: # Concatenate vm library patches.
On 2016/10/21 21:34:43, zra wrote:
> Then you can de-dup the invocation of concatenate_patch for vm_libraries and
io
> below.

Done.

https://codereview.chromium.org/2434123003/diff/40001/runtime/vm/BUILD.gn#new...
runtime/vm/BUILD.gn:383: "../../tools/list_files.py", ["dart\$",
"../../sdk/lib"], "list lines")
On 2016/10/21 21:34:43, zra wrote:
> If you only want .dart files, then tools/list_dart_files.py should be a lot
> faster.

Done.

[zra, 2016-10-25 07:06:36]

GN lgtm

https://codereview.chromium.org/2434123003/diff/60001/runtime/vm/BUILD.gn
File runtime/vm/BUILD.gn (right):

https://codereview.chromium.org/2434123003/diff/60001/runtime/vm/BUILD.gn#new...
runtime/vm/BUILD.gn:338: foreach(library, invoker.libraries) {
assert that invoker.libraries is defined.

https://codereview.chromium.org/2434123003/diff/60001/runtime/vm/BUILD.gn#new...
runtime/vm/BUILD.gn:369: # These three are not patches, they will not be in
[concatenation_files] but
six? Maybe just "The scripts below"

https://codereview.chromium.org/2434123003/diff/60001/tools/run_pub_get.py
File tools/run_pub_get.py (right):

https://codereview.chromium.org/2434123003/diff/60001/tools/run_pub_get.py#ne...
tools/run_pub_get.py:2: # Copyright (c) 2011, the Dart project authors.  Please
see the AUTHORS file
2016?

[siva, 2016-10-26 07:19:37]

lgtm

[Vyacheslav Egorov (Google), 2016-10-26 10:45:17]

Thanks for all your reviews. Landing this now.

https://codereview.chromium.org/2434123003/diff/60001/runtime/vm/BUILD.gn
File runtime/vm/BUILD.gn (right):

https://codereview.chromium.org/2434123003/diff/60001/runtime/vm/BUILD.gn#new...
runtime/vm/BUILD.gn:338: foreach(library, invoker.libraries) {
On 2016/10/25 07:06:35, zra wrote:
> assert that invoker.libraries is defined.

Done.

https://codereview.chromium.org/2434123003/diff/60001/runtime/vm/BUILD.gn#new...
runtime/vm/BUILD.gn:369: # These three are not patches, they will not be in
[concatenation_files] but
On 2016/10/25 07:06:35, zra wrote:
> six? Maybe just "The scripts below"

Done.

https://codereview.chromium.org/2434123003/diff/60001/tools/run_pub_get.py
File tools/run_pub_get.py (right):

https://codereview.chromium.org/2434123003/diff/60001/tools/run_pub_get.py#ne...
tools/run_pub_get.py:2: # Copyright (c) 2011, the Dart project authors.  Please
see the AUTHORS file
On 2016/10/25 07:06:35, zra wrote:
> 2016?

Killed this file

[Vyacheslav Egorov (Google), 2016-10-26 11:02:57]

Description was changed from

==========
Merge more Kernel infrastructure from kernel_sdk SDK fork.

- bring patched SDK generation scripts and VM patch tweaks that allow VM patch
files to be parsed by analyzer front-end;
  Patched SDK is an SDK with all VM patches spliced into it. Kernel compiler is
based on the analyzer front-end which does
  not have any patch files support/model so for it to produce Kernel files that
match VM we need to generate a such patched SDKs.

- bring test script modifications that allow to test Kernel pipeline

BUG=
==========

to

==========
Merge more Kernel infrastructure from kernel_sdk SDK fork.

- bring patched SDK generation scripts and VM patch tweaks that allow VM patch
files to be parsed by analyzer front-end;
  Patched SDK is an SDK with all VM patches spliced into it. Kernel compiler is
based on the analyzer front-end which does
  not have any patch files support/model so for it to produce Kernel files that
match VM we need to generate a such patched SDKs.

- bring test script modifications that allow to test Kernel pipeline

BUG=
R=asiva@google.com, kmillikin@google.com, whesse@google.com, zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2fed1c39053eec122fa5bfec9a123ca2c5b80500
==========

[Vyacheslav Egorov (Google), 2016-10-26 11:02:59]

Committed patchset #4 (id:60001) manually as
2fed1c39053eec122fa5bfec9a123ca2c5b80500 (presubmit successful).