runtime/bin/nativewrappers.dart - Issue 2434123003: Merge more Kernel infrastructure from kernel_sdk SDK fork.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/bin/nativewrappers.dart

Issue 2434123003: Merge more Kernel infrastructure from kernel_sdk SDK fork. (Closed)

Patch Set: Address comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file

	2 // for details. All rights solveserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 library dart.nativewrappers;

	6

	7 class NativeFieldWrapperClass1 extends Object {}
	Florian Schneider 2016/10/21 15:36:09 Are these now duplicated (in Library::InitNativeWr Are these now duplicated (in Library::InitNativeWrappersLibrary) and declared here? This should be fixed before landing. Vyacheslav Egorov (Google) 2016/10/21 15:55:32 This file is actually not included into the VM (se Show quoted text On 2016/10/21 15:36:09, Florian Schneider wrote: > Are these now duplicated (in Library::InitNativeWrappersLibrary) and declared > here? This should be fixed before landing. This file is actually not included into the VM (see gypi files - they don't mention it). Only used by analyzer. Florian Schneider 2016/10/21 17:16:02 Ok, didn't see that. Maybe add a comment about thi Show quoted text On 2016/10/21 15:55:32, Vyacheslav Egorov (Google) wrote: > On 2016/10/21 15:36:09, Florian Schneider wrote: > > Are these now duplicated (in Library::InitNativeWrappersLibrary) and declared > > here? This should be fixed before landing. > > This file is actually not included into the VM (see gypi files - they don't > mention it). Only used by analyzer. Ok, didn't see that. Maybe add a comment about this library just mirroring the VM-internal generated classes for the analyzer. Vyacheslav Egorov (Google) 2016/10/24 13:35:09 Done. Show quoted text On 2016/10/21 17:16:02, Florian Schneider wrote: > On 2016/10/21 15:55:32, Vyacheslav Egorov (Google) wrote: > > On 2016/10/21 15:36:09, Florian Schneider wrote: > > > Are these now duplicated (in Library::InitNativeWrappersLibrary) and > declared > > > here? This should be fixed before landing. > > > > This file is actually not included into the VM (see gypi files - they don't > > mention it). Only used by analyzer. > > Ok, didn't see that. Maybe add a comment about this library just mirroring the > VM-internal generated classes for the analyzer. Done.
	8 class NativeFieldWrapperClass2 extends Object {}

	9 class NativeFieldWrapperClass3 extends Object {}

	10 class NativeFieldWrapperClass4 extends Object {}

OLD	NEW

« no previous file with comments | « runtime/bin/eventhandler_patch.dart ('k') | runtime/bin/process_patch.dart » ('j') | sdk/lib/internal/internal.dart » ('J')