Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Issue 2434013003: Add coalesced KeyDown handling for arrow key scrolling. (Closed)

Created:
4 years, 2 months ago by aelias_OOO_until_Jul13
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Add coalesced KeyDown handling for arrow key scrolling. Android switched to sending coalesced KeyDown instead of RawKeyDown/Char pair in http://crrev.com/2206053002. The arrow key handler in Source/web in particular did not account for this case, therefore arrow keys stopped scrolling on Android (although all other uses of arrow keys handled in Source/core still work). NOTRY=true BUG=657158 Review-Url: https://chromiumcodereview.appspot.com/2434463003 Cr-Commit-Position: refs/heads/master@{#426289} (cherry picked from commit 5492e01d2bb022d2bdfab86250f5a4c543cea122) Committed: https://chromium.googlesource.com/chromium/src/+/59f0841b8ba5acde00049a4fe6c27bae0cd519fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
aelias_OOO_until_Jul13
4 years, 2 months ago (2016-10-19 21:53:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
59f0841b8ba5acde00049a4fe6c27bae0cd519fa.

Powered by Google App Engine
This is Rietveld 408576698