Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2434013003: Add coalesced KeyDown handling for arrow key scrolling. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1659 matching lines...) Expand 10 before | Expand all | Expand 10 after
1670 return false; 1670 return false;
1671 1671
1672 switch (event.type) { 1672 switch (event.type) {
1673 case WebInputEvent::Char: 1673 case WebInputEvent::Char:
1674 if (event.windowsKeyCode == VKEY_SPACE) { 1674 if (event.windowsKeyCode == VKEY_SPACE) {
1675 int keyCode = ((event.modifiers & WebInputEvent::ShiftKey) ? VKEY_PRIOR 1675 int keyCode = ((event.modifiers & WebInputEvent::ShiftKey) ? VKEY_PRIOR
1676 : VKEY_NEXT); 1676 : VKEY_NEXT);
1677 return scrollViewWithKeyboard(keyCode, event.modifiers); 1677 return scrollViewWithKeyboard(keyCode, event.modifiers);
1678 } 1678 }
1679 break; 1679 break;
1680 case WebInputEvent::KeyDown:
1680 case WebInputEvent::RawKeyDown: 1681 case WebInputEvent::RawKeyDown:
1681 if (event.modifiers == WebInputEvent::ControlKey) { 1682 if (event.modifiers == WebInputEvent::ControlKey) {
1682 switch (event.windowsKeyCode) { 1683 switch (event.windowsKeyCode) {
1683 #if !OS(MACOSX) 1684 #if !OS(MACOSX)
1684 case 'A': 1685 case 'A':
1685 focusedFrame()->executeCommand(WebString::fromUTF8("SelectAll")); 1686 focusedFrame()->executeCommand(WebString::fromUTF8("SelectAll"));
1686 return true; 1687 return true;
1687 case VKEY_INSERT: 1688 case VKEY_INSERT:
1688 case 'C': 1689 case 'C':
1689 focusedFrame()->executeCommand(WebString::fromUTF8("Copy")); 1690 focusedFrame()->executeCommand(WebString::fromUTF8("Copy"));
(...skipping 3054 matching lines...) Expand 10 before | Expand all | Expand 10 after
4744 if (focusedFrame->localFrameRoot() != mainFrameImpl()->frame()) 4745 if (focusedFrame->localFrameRoot() != mainFrameImpl()->frame())
4745 return nullptr; 4746 return nullptr;
4746 return focusedFrame; 4747 return focusedFrame;
4747 } 4748 }
4748 4749
4749 LocalFrame* WebViewImpl::focusedLocalFrameAvailableForIme() const { 4750 LocalFrame* WebViewImpl::focusedLocalFrameAvailableForIme() const {
4750 return m_imeAcceptEvents ? focusedLocalFrameInWidget() : nullptr; 4751 return m_imeAcceptEvents ? focusedLocalFrameInWidget() : nullptr;
4751 } 4752 }
4752 4753
4753 } // namespace blink 4754 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698