Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 2434013003: Add coalesced KeyDown handling for arrow key scrolling. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1164 matching lines...) Expand 10 before | Expand all | Expand 10 after
1175 return WebInputEventResult::NotHandled; 1175 return WebInputEventResult::NotHandled;
1176 1176
1177 switch (event.type) { 1177 switch (event.type) {
1178 case WebInputEvent::Char: 1178 case WebInputEvent::Char:
1179 if (event.windowsKeyCode == VKEY_SPACE) { 1179 if (event.windowsKeyCode == VKEY_SPACE) {
1180 int keyCode = ((event.modifiers & WebInputEvent::ShiftKey) ? VKEY_PRIOR 1180 int keyCode = ((event.modifiers & WebInputEvent::ShiftKey) ? VKEY_PRIOR
1181 : VKEY_NEXT); 1181 : VKEY_NEXT);
1182 return scrollViewWithKeyboard(keyCode, event.modifiers); 1182 return scrollViewWithKeyboard(keyCode, event.modifiers);
1183 } 1183 }
1184 break; 1184 break;
1185 case WebInputEvent::KeyDown:
1185 case WebInputEvent::RawKeyDown: 1186 case WebInputEvent::RawKeyDown:
1186 if (event.modifiers == WebInputEvent::ControlKey) { 1187 if (event.modifiers == WebInputEvent::ControlKey) {
1187 switch (event.windowsKeyCode) { 1188 switch (event.windowsKeyCode) {
1188 #if !OS(MACOSX) 1189 #if !OS(MACOSX)
1189 case 'A': 1190 case 'A':
1190 WebFrame::fromFrame(focusedCoreFrame()) 1191 WebFrame::fromFrame(focusedCoreFrame())
1191 ->toWebLocalFrame() 1192 ->toWebLocalFrame()
1192 ->executeCommand(WebString::fromUTF8("SelectAll")); 1193 ->executeCommand(WebString::fromUTF8("SelectAll"));
1193 return WebInputEventResult::HandledSystem; 1194 return WebInputEventResult::HandledSystem;
1194 case VKEY_INSERT: 1195 case VKEY_INSERT:
(...skipping 326 matching lines...) Expand 10 before | Expand all | Expand 10 after
1521 return flags; 1522 return flags;
1522 } 1523 }
1523 1524
1524 LocalFrame* WebFrameWidgetImpl::focusedLocalFrameAvailableForIme() const { 1525 LocalFrame* WebFrameWidgetImpl::focusedLocalFrameAvailableForIme() const {
1525 if (!m_imeAcceptEvents) 1526 if (!m_imeAcceptEvents)
1526 return nullptr; 1527 return nullptr;
1527 return focusedLocalFrameInWidget(); 1528 return focusedLocalFrameInWidget();
1528 } 1529 }
1529 1530
1530 } // namespace blink 1531 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698