Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2432473002: Remove ZeroPole class and files (Closed)

Created:
4 years, 2 months ago by Raymond Toy
Modified:
4 years, 1 month ago
Reviewers:
esprehn, hongchan
CC:
blink-reviews, chromium-reviews, hongchan, Raymond Toy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ZeroPole class and files The ZeroPole class is not used anywhere and therefore not tested. Remove it. BUG=657033 TEST=compile still works Committed: https://crrev.com/2d3ac961d2ae9ff01eba996a8c63d7ce18556445 Cr-Commit-Position: refs/heads/master@{#430406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -142 lines) Patch
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/DynamicsCompressor.h View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/platform/audio/ZeroPole.h View 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/WebKit/Source/platform/audio/ZeroPole.cpp View 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
Raymond Toy
PTAL
4 years, 2 months ago (2016-10-18 17:32:27 UTC) #4
Raymond Toy
Ping
4 years, 1 month ago (2016-10-31 15:10:19 UTC) #7
hongchan
lgtm
4 years, 1 month ago (2016-10-31 20:45:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432473002/1
4 years, 1 month ago (2016-10-31 20:49:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/293488)
4 years, 1 month ago (2016-10-31 21:03:40 UTC) #12
Raymond Toy
PTAL at BUILD.gn---just removing the two unused files.
4 years, 1 month ago (2016-10-31 22:22:58 UTC) #14
esprehn
lgtm
4 years, 1 month ago (2016-11-04 22:44:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432473002/1
4 years, 1 month ago (2016-11-07 16:37:21 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/175621)
4 years, 1 month ago (2016-11-07 18:10:55 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432473002/1
4 years, 1 month ago (2016-11-07 22:08:05 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 23:04:47 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 23:07:38 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d3ac961d2ae9ff01eba996a8c63d7ce18556445
Cr-Commit-Position: refs/heads/master@{#430406}

Powered by Google App Engine
This is Rietveld 408576698