Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2430503002: MD Settings: Migrate omnibox extension action menu to settings-action-menu. (Closed)

Created:
4 years, 2 months ago by dpapad
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Migrate omnibox extension action menu to settings-action-menu. BUG=639718 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/91eece85eebeafb1e5f75716059f61b88b5faef2 Cr-Commit-Position: refs/heads/master@{#425797}

Patch Set 1 #

Patch Set 2 : Convert more #

Patch Set 3 : Undo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -17 lines) Patch
M chrome/browser/resources/settings/search_engines_page/compiled_resources2.gyp View 1 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html View 2 chunks +13 lines, -16 lines 0 comments Download
M chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/test/data/webui/settings/search_engines_page_test.js View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
dpapad
4 years, 2 months ago (2016-10-17 21:04:30 UTC) #9
Dan Beam
lgtm
4 years, 2 months ago (2016-10-17 21:10:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2430503002/40001
4 years, 2 months ago (2016-10-17 21:23:58 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-17 22:42:14 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 22:45:38 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/91eece85eebeafb1e5f75716059f61b88b5faef2
Cr-Commit-Position: refs/heads/master@{#425797}

Powered by Google App Engine
This is Rietveld 408576698