chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js - Issue 2430503002: MD Settings: Migrate omnibox extension action menu to settings-action-menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js

Issue 2430503002: MD Settings: Migrate omnibox extension action menu to settings-action-menu. (Closed)

Patch Set: Undo Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html ('k') | chrome/test/data/webui/settings/search_engines_page_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js

diff --git a/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js b/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js

index 0ed0c9f5cd1edab48fbddc81f32c15713c8f1c24..8b34bd129863d58eba87a16d6500f73171778b57 100644

--- a/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js

+++ b/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js

@@ -36,7 +36,7 @@ Polymer({

/** @private */

closePopupMenu_: function() {

- this.$$('iron-dropdown').close();

+ this.$$('dialog[is=settings-action-menu]').close();

/**

@@ -47,4 +47,11 @@ Polymer({

getIconSet_: function(url) {

return cr.icon.getFavicon(url);

+ /** @private */

+ onDotsTap_: function() {

+ /** @type {!SettingsActionMenuElement} */ (

+ this.$$('dialog[is=settings-action-menu]')).showAt(

+ assert(this.$$('paper-icon-button')));

+ },

});