Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Unified Diff: chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html

Issue 2430503002: MD Settings: Migrate omnibox extension action menu to settings-action-menu. (Closed)
Patch Set: Undo Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
diff --git a/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html b/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
index 0a08f0c58fcdbec54fdfbb89044e0dcf7556ca36..382a349219452a84740bb85fb09c809e8ad20ec2 100644
--- a/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
+++ b/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
@@ -2,8 +2,8 @@
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/html/icon.html">
<link rel="import" href="/search_engines_page/search_engines_browser_proxy.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-dropdown.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
+<link rel="import" href="/settings_action_menu.html">
<link rel="import" href="/settings_shared_css.html">
<dom-module id="settings-omnibox-extension-entry">
@@ -25,22 +25,19 @@
<span class="name">[[engine.displayName]]</span>
</div>
<div class="keyword-column">[[engine.keyword]]</div>
- <paper-icon-button icon="cr:more-vert" toggles tabindex$="[[tabindex]]"
- active="{{editMenuOpened}}">
+ <paper-icon-button icon="cr:more-vert" tabindex$="[[tabindex]]"
+ on-tap="onDotsTap_">
</paper-icon-button>
- <iron-dropdown opened="{{editMenuOpened}}" horizontal-align="right"
- vertical-align="auto">
- <div class="dropdown-content">
- <button class="dropdown-item" role="option" on-tap="onManageTap_"
- id="manage">
- $i18n{searchEnginesManageExtension}
- </button>
- <button class="dropdown-item" role="option" on-tap="onDisableTap_"
- id="disable">
- $i18n{disable}
- </button>
- <div>
- </iron-dropdown>
+ <dialog is="settings-action-menu">
+ <button class="dropdown-item" role="option" on-tap="onManageTap_"
+ id="manage">
+ $i18n{searchEnginesManageExtension}
+ </button>
+ <button class="dropdown-item" role="option" on-tap="onDisableTap_"
+ id="disable">
+ $i18n{disable}
+ </button>
+ </dialog>
</div>
</template>
<script src="omnibox_extension_entry.js"></script>

Powered by Google App Engine
This is Rietveld 408576698