Cleanup options for use of application snapshots

Cleanup options for use of application snapshots
 - unified kAppAfterRun and kAppJITAfterRun to kAppJIT
 - adjusted the test configuration to make dart2app and dart2appjit to mean
   the same
 - delete GenerateFullSnapshot function as it is not used anymore

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/af4d246ef1f740e79af21cac0e3a7126f003a8aa

[siva, 2016-10-18 21:23:26]

asiva@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-10-18 23:55:46]

https://codereview.chromium.org/2429023002/diff/40001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/2429023002/diff/40001/runtime/bin/main.cc#new...
runtime/bin/main.cc:52: *   dart <app_snapshot_filename> [<script_options>]
We still need the no code option as a command line flag to support cross
compiling.

E.g., a cross ARM build should pass --snapshot-kind=app but a host ARM build
should pass --snapshot-kind=app-jit.

Compare https://codereview.chromium.org/2433573002/diff/1/tools/gn.py

[rmacnak, 2016-10-19 17:41:21]

https://chromiumcodereview.appspot.com/2429023002/diff/40001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://chromiumcodereview.appspot.com/2429023002/diff/40001/runtime/bin/main...
runtime/bin/main.cc:1639: if (!Dart_IsCompilationError(result) &&
To get us going, perhaps

#if defined(TARGET_ARCH_X64)
   Dart_Handle prepare_result = Dart_PrecompileJIT();	
   CHECK_RESULT(prepare_result);	
   GeneratePrecompiledJITSnapshot();
#else
   GenerateFullSnapshot();
#endif

https://chromiumcodereview.appspot.com/2429023002/diff/40001/tools/testing/da...
File tools/testing/dart/compiler_configuration.dart (right):

https://chromiumcodereview.appspot.com/2429023002/diff/40001/tools/testing/da...
tools/testing/dart/compiler_configuration.dart:81: case 'dart2appjit':
If there's going to be only one --snapshot-kind for the VM, then test.py should
only have one --compiler.

[siva, 2016-10-19 22:16:52]

https://chromiumcodereview.appspot.com/2429023002/diff/40001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://chromiumcodereview.appspot.com/2429023002/diff/40001/runtime/bin/main...
runtime/bin/main.cc:52: *   dart <app_snapshot_filename> [<script_options>]
On 2016/10/18 23:55:46, rmacnak wrote:
> We still need the no code option as a command line flag to support cross
> compiling.
> 
> E.g., a cross ARM build should pass --snapshot-kind=app but a host ARM build
> should pass --snapshot-kind=app-jit.
> 
> Compare https://codereview.chromium.org/2433573002/diff/1/tools/gn.py

Addressed by the change of generating an app snapshot with code only for the X64
target.

https://chromiumcodereview.appspot.com/2429023002/diff/40001/runtime/bin/main...
runtime/bin/main.cc:1639: if (!Dart_IsCompilationError(result) &&
On 2016/10/19 17:41:21, rmacnak wrote:
> To get us going, perhaps
> 
> #if defined(TARGET_ARCH_X64)
>    Dart_Handle prepare_result = Dart_PrecompileJIT();	
>    CHECK_RESULT(prepare_result);	
>    GeneratePrecompiledJITSnapshot();
> #else
>    GenerateFullSnapshot();
> #endif

Done.

https://chromiumcodereview.appspot.com/2429023002/diff/40001/tools/testing/da...
File tools/testing/dart/compiler_configuration.dart (right):

https://chromiumcodereview.appspot.com/2429023002/diff/40001/tools/testing/da...
tools/testing/dart/compiler_configuration.dart:81: case 'dart2appjit':
On 2016/10/19 17:41:21, rmacnak wrote:
> If there's going to be only one --snapshot-kind for the VM, then test.py
should
> only have one --compiler.

It has only one compiler but two options doing the same thing.
I wanted the compiler to be called dart2app but that would mean
changing the buildbot to use dart2app instead of dart2appjit.

Once I fix the buildbot script, I should be able to remove dart2appjit.

[rmacnak, 2016-10-19 23:45:14]

lgtm

[siva, 2016-10-20 00:42:06]

Description was changed from

==========
Cleanup options for use of application snapshots
 - unified kAppAfterRun and kAppJITAfterRun to kAppJIT
 - adjusted the test configuration to make dart2app and dart2appjit to mean
   the same
 - delete GenerateFullSnapshot function as it is not used anymore
==========

to

==========
Cleanup options for use of application snapshots
 - unified kAppAfterRun and kAppJITAfterRun to kAppJIT
 - adjusted the test configuration to make dart2app and dart2appjit to mean
   the same
 - delete GenerateFullSnapshot function as it is not used anymore

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/af4d246ef1f740e79af21cac0e3a7126f003a8aa
==========

[siva, 2016-10-20 00:42:07]

Committed patchset #4 (id:60001) manually as
af4d246ef1f740e79af21cac0e3a7126f003a8aa (presubmit successful).