Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: tools/testing/dart/test_options.dart

Issue 2429023002: Cleanup options for use of application snapshots (Closed)
Patch Set: Address code review comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index 936bb39a05bec776f6c7cf70d3a1c496d1e65b37..255564ac5c1688a84428a97b19f7fa2333f0428a 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -73,8 +73,9 @@ class TestOptionsParser {
dart2analyzer: Perform static analysis on Dart code by running the analyzer
(only valid with the following runtimes: none)
- dart2app: Compile the Dart code into an app snapshot before running the test
- (only valid with the following runtimes: dart_app)''',
+ dart2app:
+ dart2appjit: Compile the Dart code into an app snapshot before running test
+ (only valid with dart_app runtime)''',
['-c', '--compiler'],
['none', 'precompiler', 'dart2js', 'dart2analyzer', 'dart2app', 'dart2appjit'],
'none'),
@@ -670,8 +671,6 @@ Note: currently only implemented for dart2js.''',
validRuntimes = const ['none'];
break;
case 'dart2app':
- validRuntimes = const ['dart_app'];
- break;
case 'dart2appjit':
validRuntimes = const ['dart_app'];
break;
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698