Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: tools/testing/dart/test_options.dart

Issue 2429023002: Cleanup options for use of application snapshots (Closed)
Patch Set: Address code review comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test_options_parser; 5 library test_options_parser;
6 6
7 import "dart:io"; 7 import "dart:io";
8 import "drt_updater.dart"; 8 import "drt_updater.dart";
9 import "test_suite.dart"; 9 import "test_suite.dart";
10 import "path.dart"; 10 import "path.dart";
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 (only valid with the following runtimes: vm, drt) 66 (only valid with the following runtimes: vm, drt)
67 67
68 dart2js: Compile dart code to JavaScript by running dart2js. 68 dart2js: Compile dart code to JavaScript by running dart2js.
69 (only valid with the following runtimes: d8, drt, chrome, 69 (only valid with the following runtimes: d8, drt, chrome,
70 safari, ie9, ie10, ie11, firefox, opera, chromeOnAndroid, 70 safari, ie9, ie10, ie11, firefox, opera, chromeOnAndroid,
71 none (compile only)), 71 none (compile only)),
72 72
73 dart2analyzer: Perform static analysis on Dart code by running the analyzer 73 dart2analyzer: Perform static analysis on Dart code by running the analyzer
74 (only valid with the following runtimes: none) 74 (only valid with the following runtimes: none)
75 75
76 dart2app: Compile the Dart code into an app snapshot before running the test 76 dart2app:
77 (only valid with the following runtimes: dart_app)''', 77 dart2appjit: Compile the Dart code into an app snapshot before running test
78 (only valid with dart_app runtime)''',
78 ['-c', '--compiler'], 79 ['-c', '--compiler'],
79 ['none', 'precompiler', 'dart2js', 'dart2analyzer', 'dart2app', 'dart2 appjit'], 80 ['none', 'precompiler', 'dart2js', 'dart2analyzer', 'dart2app', 'dart2 appjit'],
80 'none'), 81 'none'),
81 // TODO(antonm): fix the option drt. 82 // TODO(antonm): fix the option drt.
82 new _TestOptionSpecification( 83 new _TestOptionSpecification(
83 'runtime', 84 'runtime',
84 '''Where the tests should be run. 85 '''Where the tests should be run.
85 vm: Run Dart code on the standalone dart vm. 86 vm: Run Dart code on the standalone dart vm.
86 87
87 dart_precompiled: Run a precompiled snapshot on a variant of the standalone 88 dart_precompiled: Run a precompiled snapshot on a variant of the standalone
(...skipping 575 matching lines...) Expand 10 before | Expand all | Expand 10 after
663 'ie11', 664 'ie11',
664 'opera', 665 'opera',
665 'chromeOnAndroid', 666 'chromeOnAndroid',
666 'safarimobilesim' 667 'safarimobilesim'
667 ]; 668 ];
668 break; 669 break;
669 case 'dart2analyzer': 670 case 'dart2analyzer':
670 validRuntimes = const ['none']; 671 validRuntimes = const ['none'];
671 break; 672 break;
672 case 'dart2app': 673 case 'dart2app':
673 validRuntimes = const ['dart_app'];
674 break;
675 case 'dart2appjit': 674 case 'dart2appjit':
676 validRuntimes = const ['dart_app']; 675 validRuntimes = const ['dart_app'];
677 break; 676 break;
678 case 'precompiler': 677 case 'precompiler':
679 validRuntimes = const ['dart_precompiled']; 678 validRuntimes = const ['dart_precompiled'];
680 break; 679 break;
681 case 'none': 680 case 'none':
682 validRuntimes = const [ 681 validRuntimes = const [
683 'vm', 682 'vm',
684 'drt', 683 'drt',
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
959 if (option.keys.contains(name)) { 958 if (option.keys.contains(name)) {
960 return option; 959 return option;
961 } 960 }
962 } 961 }
963 print('Unknown test option $name'); 962 print('Unknown test option $name');
964 exit(1); 963 exit(1);
965 } 964 }
966 965
967 List<_TestOptionSpecification> _options; 966 List<_TestOptionSpecification> _options;
968 } 967 }
OLDNEW
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698