third_party/WebKit/public/web/WebLocalFrame.h - Issue 2428803002: Don't send loading completion callbacks for detaching frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebLocalFrame.h

Issue 2428803002: Don't send loading completion callbacks for detaching frames. (Closed)

Patch Set: . Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/public/web/WebLocalFrame.h

diff --git a/third_party/WebKit/public/web/WebLocalFrame.h b/third_party/WebKit/public/web/WebLocalFrame.h

index 1e6d90dc3233296bfb90a4e658a30a14572721e7..aa9c3741eb99baa4fc3e24178d4b7496c35f7b58 100644

--- a/third_party/WebKit/public/web/WebLocalFrame.h

+++ b/third_party/WebKit/public/web/WebLocalFrame.h

@@ -128,10 +128,6 @@ class WebLocalFrame : public WebFrame {

// Returns true if the current frame's load event has not completed.

virtual bool isLoading() const = 0;

- // Returns true if the current frame is detaching/detached. crbug.com/654654

- virtual bool isFrameDetachedForSpecialOneOffStopTheCrashingHackBug561873()

Nate Chapin 2016/10/21 18:31:44 That is a fantastic function name.

- const = 0;

// Returns true if there is a pending redirect or location change

// within specified interval (in seconds). This could be caused by:

// * an HTTP Refresh header

« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | no next file » | no next file with comments »