Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/public/web/WebLocalFrame.h

Issue 2428803002: Don't send loading completion callbacks for detaching frames. (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebLocalFrame_h 5 #ifndef WebLocalFrame_h
6 #define WebLocalFrame_h 6 #define WebLocalFrame_h
7 7
8 #include "WebCompositionUnderline.h" 8 #include "WebCompositionUnderline.h"
9 #include "WebFrame.h" 9 #include "WebFrame.h"
10 #include "WebFrameLoadType.h" 10 #include "WebFrameLoadType.h"
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 WebFrameLoadType = WebFrameLoadType::Standard, 121 WebFrameLoadType = WebFrameLoadType::Standard,
122 const WebHistoryItem& = WebHistoryItem(), 122 const WebHistoryItem& = WebHistoryItem(),
123 WebHistoryLoadType = WebHistoryDifferentDocumentLoad, 123 WebHistoryLoadType = WebHistoryDifferentDocumentLoad,
124 bool isClientRedirect = false) = 0; 124 bool isClientRedirect = false) = 0;
125 125
126 // Navigation State ------------------------------------------------------- 126 // Navigation State -------------------------------------------------------
127 127
128 // Returns true if the current frame's load event has not completed. 128 // Returns true if the current frame's load event has not completed.
129 virtual bool isLoading() const = 0; 129 virtual bool isLoading() const = 0;
130 130
131 // Returns true if the current frame is detaching/detached. crbug.com/654654
132 virtual bool isFrameDetachedForSpecialOneOffStopTheCrashingHackBug561873()
Nate Chapin 2016/10/21 18:31:44 That is a fantastic function name.
133 const = 0;
134
135 // Returns true if there is a pending redirect or location change 131 // Returns true if there is a pending redirect or location change
136 // within specified interval (in seconds). This could be caused by: 132 // within specified interval (in seconds). This could be caused by:
137 // * an HTTP Refresh header 133 // * an HTTP Refresh header
138 // * an X-Frame-Options header 134 // * an X-Frame-Options header
139 // * the respective http-equiv meta tags 135 // * the respective http-equiv meta tags
140 // * window.location value being mutated 136 // * window.location value being mutated
141 // * CSP policy block 137 // * CSP policy block
142 // * reload 138 // * reload
143 // * form submission 139 // * form submission
144 virtual bool isNavigationScheduledWithin(double intervalInSeconds) const = 0; 140 virtual bool isNavigationScheduledWithin(double intervalInSeconds) const = 0;
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 // to call these on a WebLocalFrame. 453 // to call these on a WebLocalFrame.
458 bool isWebLocalFrame() const override = 0; 454 bool isWebLocalFrame() const override = 0;
459 WebLocalFrame* toWebLocalFrame() override = 0; 455 WebLocalFrame* toWebLocalFrame() override = 0;
460 bool isWebRemoteFrame() const override = 0; 456 bool isWebRemoteFrame() const override = 0;
461 WebRemoteFrame* toWebRemoteFrame() override = 0; 457 WebRemoteFrame* toWebRemoteFrame() override = 0;
462 }; 458 };
463 459
464 } // namespace blink 460 } // namespace blink
465 461
466 #endif // WebLocalFrame_h 462 #endif // WebLocalFrame_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698