third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2428803002: Don't send loading completion callbacks for detaching frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2428803002: Don't send loading completion callbacks for detaching frames. (Closed)

Patch Set: . Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 58ada7277f3b6b973e9ec7388aaada886650367e..6ed922c331b517f32549c6ffb41da523db6be3a8 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -2060,11 +2060,6 @@ bool WebLocalFrameImpl::isLoading() const {

!frame()->document()->loadEventFinished();

}

-bool WebLocalFrameImpl::

- isFrameDetachedForSpecialOneOffStopTheCrashingHackBug561873() const {

- return !frame() || frame()->isDetaching();

bool WebLocalFrameImpl::isNavigationScheduledWithin(

double intervalInSeconds) const {

return frame() &&