Make Document::m_IconList a vector of IconElements.

Make Document::m_IconList a vector of IconElements.

There's no need for std::list<std::unique_ptr<IconElement>>.

Committed: https://pdfium.googlesource.com/pdfium/+/f328d0d378b8df8a3416988d96c34f1d3f9d26d1

[Lei Zhang, 2016-10-18 19:07:29]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 19:07:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 19:17:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 19:17:09]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-10-18 19:28:23]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org, npm@chromium.org

[npm, 2016-10-18 19:34:45]

lgtm

https://codereview.chromium.org/2428743004/diff/1/fpdfsdk/javascript/Document...
File fpdfsdk/javascript/Document.cpp (right):

https://codereview.chromium.org/2428743004/diff/1/fpdfsdk/javascript/Document...
fpdfsdk/javascript/Document.cpp:1323: Icon* pRetIcon = element.IconStream;
Remove

https://codereview.chromium.org/2428743004/diff/1/fpdfsdk/javascript/Document...
fpdfsdk/javascript/Document.cpp:1340: pIcon->SetStream(pRetIcon->GetStream());
pIcon->SetStream(element.IconStream->GetStream());

[Lei Zhang, 2016-10-18 22:28:44]

https://codereview.chromium.org/2428743004/diff/1/fpdfsdk/javascript/Document...
File fpdfsdk/javascript/Document.cpp (right):

https://codereview.chromium.org/2428743004/diff/1/fpdfsdk/javascript/Document...
fpdfsdk/javascript/Document.cpp:1323: Icon* pRetIcon = element.IconStream;
On 2016/10/18 19:34:45, npm wrote:
> Remove

Done.

https://codereview.chromium.org/2428743004/diff/1/fpdfsdk/javascript/Document...
fpdfsdk/javascript/Document.cpp:1340: pIcon->SetStream(pRetIcon->GetStream());
On 2016/10/18 19:34:45, npm wrote:
> pIcon->SetStream(element.IconStream->GetStream());

Done.

[Lei Zhang, 2016-10-18 22:28:48]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-10-18 22:28:48]

The patchset sent to the CQ was uploaded after l-g-t-m from npm@chromium.org
Link to the patchset: https://codereview.chromium.org/2428743004/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2016-10-18 22:28:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 22:38:25]

Description was changed from

==========
Make Document::m_IconList a vector of IconElements.

There's no need for std::list<std::unique_ptr<IconElement>>.
==========

to

==========
Make Document::m_IconList a vector of IconElements.

There's no need for std::list<std::unique_ptr<IconElement>>.

Committed:
https://pdfium.googlesource.com/pdfium/+/f328d0d378b8df8a3416988d96c34f1d3f9d...
==========

[commit-bot: I haz the power, 2016-10-18 22:38:26]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/f328d0d378b8df8a3416988d96c34f1d3f9d...

[dsinclair, 2016-10-19 02:26:19]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2431913003/ by dsinclair@chromium.org.

The reason for reverting is: Appears to be blocking the roll due to compile
failure https://codereview.chromium.org/2429053002

Attempting to revert to see if the roll will pass..