Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: fpdfsdk/javascript/Document.cpp

Issue 2428743004: Make Document::m_IconList a vector of IconElements. (Closed)
Patch Set: nits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/javascript/Document.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/javascript/Document.cpp
diff --git a/fpdfsdk/javascript/Document.cpp b/fpdfsdk/javascript/Document.cpp
index 0b08f66f338a7142a2ec76e187ab0d856a6c5fe5..4b597ae12763daec4ef99a2a93b996e9062e5219 100644
--- a/fpdfsdk/javascript/Document.cpp
+++ b/fpdfsdk/javascript/Document.cpp
@@ -1256,8 +1256,7 @@ FX_BOOL Document::addIcon(IJS_Context* cc,
return FALSE;
}
- m_IconList.push_back(std::unique_ptr<IconElement>(
- new IconElement(swIconName, (Icon*)pEmbedObj)));
+ m_Icons.push_back(IconElement(swIconName, static_cast<Icon*>(pEmbedObj)));
return TRUE;
}
@@ -1270,7 +1269,7 @@ FX_BOOL Document::icons(IJS_Context* cc,
}
CJS_Runtime* pRuntime = CJS_Runtime::FromContext(cc);
- if (m_IconList.empty()) {
+ if (m_Icons.empty()) {
vp.GetJSValue()->SetNull(pRuntime);
return TRUE;
}
@@ -1278,7 +1277,7 @@ FX_BOOL Document::icons(IJS_Context* cc,
CJS_Array Icons;
int i = 0;
- for (const auto& pIconElement : m_IconList) {
+ for (const auto& element : m_Icons) {
v8::Local<v8::Object> pObj =
pRuntime->NewFxDynamicObj(CJS_Icon::g_nObjDefnID);
if (pObj.IsEmpty())
@@ -1289,12 +1288,12 @@ FX_BOOL Document::icons(IJS_Context* cc,
if (!pJS_Icon)
return FALSE;
- Icon* pIcon = (Icon*)pJS_Icon->GetEmbedObject();
+ Icon* pIcon = static_cast<Icon*>(pJS_Icon->GetEmbedObject());
if (!pIcon)
return FALSE;
- pIcon->SetStream(pIconElement->IconStream->GetStream());
- pIcon->SetIconName(pIconElement->IconName);
+ pIcon->SetStream(element.IconStream->GetStream());
+ pIcon->SetIconName(element.IconName);
Icons.SetElement(pRuntime, i++, CJS_Value(pRuntime, pJS_Icon));
}
@@ -1311,35 +1310,34 @@ FX_BOOL Document::getIcon(IJS_Context* cc,
return FALSE;
}
- if (m_IconList.empty())
+ if (m_Icons.empty())
return FALSE;
CJS_Runtime* pRuntime = CJS_Runtime::FromContext(cc);
CFX_WideString swIconName = params[0].ToCFXWideString(pRuntime);
- for (const auto& pIconElement : m_IconList) {
- if (pIconElement->IconName == swIconName) {
- Icon* pRetIcon = pIconElement->IconStream;
+ for (const auto& element : m_Icons) {
+ if (element.IconName != swIconName)
+ continue;
- v8::Local<v8::Object> pObj =
- pRuntime->NewFxDynamicObj(CJS_Icon::g_nObjDefnID);
- if (pObj.IsEmpty())
- return FALSE;
+ v8::Local<v8::Object> pObj =
+ pRuntime->NewFxDynamicObj(CJS_Icon::g_nObjDefnID);
+ if (pObj.IsEmpty())
+ return FALSE;
- CJS_Icon* pJS_Icon =
- static_cast<CJS_Icon*>(pRuntime->GetObjectPrivate(pObj));
- if (!pJS_Icon)
- return FALSE;
+ CJS_Icon* pJS_Icon =
+ static_cast<CJS_Icon*>(pRuntime->GetObjectPrivate(pObj));
+ if (!pJS_Icon)
+ return FALSE;
- Icon* pIcon = (Icon*)pJS_Icon->GetEmbedObject();
- if (!pIcon)
- return FALSE;
+ Icon* pIcon = static_cast<Icon*>(pJS_Icon->GetEmbedObject());
+ if (!pIcon)
+ return FALSE;
- pIcon->SetIconName(swIconName);
- pIcon->SetStream(pRetIcon->GetStream());
- vRet = CJS_Value(pRuntime, pJS_Icon);
- return TRUE;
- }
+ pIcon->SetIconName(swIconName);
+ pIcon->SetStream(element.IconStream->GetStream());
+ vRet = CJS_Value(pRuntime, pJS_Icon);
+ return TRUE;
}
return FALSE;
« no previous file with comments | « fpdfsdk/javascript/Document.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698