Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2431913003: Revert of Make Document::m_IconList a vector of IconElements. (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Make Document::m_IconList a vector of IconElements. (patchset #2 id:20001 of https://codereview.chromium.org/2428743004/ ) Reason for revert: Appears to be blocking the roll due to compile failure https://codereview.chromium.org/2429053002 Attempting to revert to see if the roll will pass. Original issue's description: > Make Document::m_IconList a vector of IconElements. > > There's no need for std::list<std::unique_ptr<IconElement>>. > > Committed: https://pdfium.googlesource.com/pdfium/+/f328d0d378b8df8a3416988d96c34f1d3f9d26d1 TBR=npm@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://pdfium.googlesource.com/pdfium/+/09bad1cf251c68d1492af4049e1324a46d9c9725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -36 lines) Patch
M fpdfsdk/javascript/Document.h View 5 chunks +6 lines, -7 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 5 chunks +31 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dsinclair
Created Revert of Make Document::m_IconList a vector of IconElements.
4 years, 2 months ago (2016-10-19 02:26:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431913003/1
4 years, 2 months ago (2016-10-19 02:26:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/09bad1cf251c68d1492af4049e1324a46d9c9725
4 years, 2 months ago (2016-10-19 02:26:37 UTC) #5
Lei Zhang
4 years, 2 months ago (2016-10-19 03:38:09 UTC) #6
Message was sent while issue was closed.
Beh, ok.

Powered by Google App Engine
This is Rietveld 408576698