Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24278008: [oilpan] Handlify Nodes in htmlediting (Closed)

Created:
7 years, 3 months ago by haraken
Modified:
7 years, 2 months ago
CC:
blink-reviews, adamk+oilpan_chromium.org, Mads Ager (chromium), abarth-chromium
Visibility:
Public.

Description

[oilpan] Handlify Nodes in htmlediting This CL gets rid of a bunch of adoptRawResult and handle().raw() in editing/. R=ager@chromium.org, zerny@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158337

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+637 lines, -622 lines) Patch
M Source/core/accessibility/AccessibilityObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/accessibility/AccessibilityRenderObject.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Position.cpp View 20 chunks +24 lines, -24 lines 0 comments Download
M Source/core/dom/PositionIterator.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/ApplyBlockElementCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 23 chunks +34 lines, -34 lines 0 comments Download
M Source/core/editing/BreakBlockquoteCommand.cpp View 3 chunks +7 lines, -3 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 24 chunks +33 lines, -33 lines 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 16 chunks +39 lines, -39 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/Editor.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M Source/core/editing/FormatBlockCommand.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/IndentOutdentCommand.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M Source/core/editing/InsertLineBreakCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/InsertListCommand.cpp View 9 chunks +18 lines, -18 lines 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/InsertTextCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/ModifySelectionListLevel.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 33 chunks +53 lines, -53 lines 1 comment Download
M Source/core/editing/TextIterator.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/TypingCommand.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 7 chunks +15 lines, -15 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 16 chunks +36 lines, -32 lines 0 comments Download
M Source/core/editing/htmlediting.h View 7 chunks +53 lines, -53 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 30 chunks +184 lines, -179 lines 0 comments Download
M Source/core/editing/markup.cpp View 12 chunks +35 lines, -33 lines 0 comments Download
M Source/core/page/DOMSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/DragController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/FocusController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Frame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
haraken
PTAL
7 years, 3 months ago (2013-09-24 00:48:11 UTC) #1
Mads Ager (chromium)
LGTM https://codereview.chromium.org/24278008/diff/1/Source/core/editing/ReplaceSelectionCommand.cpp File Source/core/editing/ReplaceSelectionCommand.cpp (right): https://codereview.chromium.org/24278008/diff/1/Source/core/editing/ReplaceSelectionCommand.cpp#newcode889 Source/core/editing/ReplaceSelectionCommand.cpp:889: inline Node* nodeToSplitToAvoidPastingIntoInlineNodesWithStyle(const Position& insertionPos) I believe this ...
7 years, 3 months ago (2013-09-24 06:36:20 UTC) #2
zerny-chromium
lgtm
7 years, 3 months ago (2013-09-24 06:47:32 UTC) #3
haraken
7 years, 2 months ago (2013-09-25 20:19:22 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r158337.

Powered by Google App Engine
This is Rietveld 408576698