Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: Source/core/editing/ModifySelectionListLevel.cpp

Issue 24278008: [oilpan] Handlify Nodes in htmlediting (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/ModifySelectionListLevel.cpp
diff --git a/Source/core/editing/ModifySelectionListLevel.cpp b/Source/core/editing/ModifySelectionListLevel.cpp
index e1dbeda98ddab84efcc38efcbcd005fd96e6c95d..10c8361fb92e30cb3074e0a3578f04c7b8527438 100644
--- a/Source/core/editing/ModifySelectionListLevel.cpp
+++ b/Source/core/editing/ModifySelectionListLevel.cpp
@@ -52,12 +52,12 @@ static bool getStartEndListChildren(const VisibleSelection& selection, Handle<No
return false;
// start must be in a list child
- Handle<Node> startListChild = adoptRawResult(enclosingListChild(selection.start().anchorNode().handle().raw()));
+ Handle<Node> startListChild = enclosingListChild(selection.start().anchorNode());
if (!startListChild)
return false;
// end must be in a list child
- Handle<Node> endListChild = selection.isRange() ? adoptRawResult(enclosingListChild(selection.end().anchorNode().handle().raw())) : Result<Node>(startListChild);
+ Handle<Node> endListChild = selection.isRange() ? enclosingListChild(selection.end().anchorNode()).handle() : startListChild;
if (!endListChild)
return false;
@@ -79,7 +79,7 @@ static bool getStartEndListChildren(const VisibleSelection& selection, Handle<No
// if the selection ends on a list item with a sublist, include the entire sublist
if (endListChild->renderer()->isListItem()) {
RenderObject* r = endListChild->renderer()->nextSibling();
- if (r && isListElement(r->node().handle().raw()))
+ if (r && isListElement(r->node()))
endListChild = r->node();
}
@@ -180,7 +180,7 @@ void IncreaseSelectionListLevelCommand::doApply()
return;
Handle<Node> previousItem = startListChild->renderer()->previousSibling()->node();
- if (isListElement(previousItem.raw())) {
+ if (isListElement(previousItem)) {
// move nodes up into preceding list
appendSiblingNodeRange(startListChild, endListChild, toElement(previousItem));
m_listElement = previousItem;
@@ -249,7 +249,7 @@ static bool canDecreaseListLevel(const VisibleSelection& selection, Handle<Node>
return false;
// there must be a destination list to move the items to
- if (!isListElement(start->parentNode()->parentNode().handle().raw()))
+ if (!isListElement(start->parentNode()->parentNode()))
return false;
return true;

Powered by Google App Engine
This is Rietveld 408576698