Issue 2427463002: VDA unittest: fix ~GLRenderingVDAClient crash in debug build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2427463002: VDA unittest: fix ~GLRenderingVDAClient crash in debug build. (Closed)

Created:
4 years, 2 months ago by kcwu

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

VDA unittest: fix ~GLRenderingVDAClient crash in debug build. This was introduced by 386d72414e61c5e8155b66e2986fa0039f4b010a. GLRenderingVDAClient uses ClientStateNotification and must be deleted first. BUG=654429 TEST=Run VDA unittest on peach pi. Review-Url: https://codereview.chromium.org/2407863002 Cr-Commit-Position: refs/heads/master@{#424366} (cherry picked from commit dc834a8f5707c31894ddebc8f12faf2cd4d2d434) Committed: https://chromium.googlesource.com/chromium/src/+/c3ed32e48a48ad27f1a5ccd248b9533aada75b29

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	media/gpu/video_decode_accelerator_unittest.cc	View		1 chunk	+5 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

kcwu

4 years, 2 months ago (2016-10-17 05:06:56 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c3ed32e48a48ad27f1a5ccd248b9533aada75b29.