Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1418)

Unified Diff: media/gpu/video_decode_accelerator_unittest.cc

Issue 2427463002: VDA unittest: fix ~GLRenderingVDAClient crash in debug build. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/gpu/video_decode_accelerator_unittest.cc
diff --git a/media/gpu/video_decode_accelerator_unittest.cc b/media/gpu/video_decode_accelerator_unittest.cc
index 365859f06397bc8f15358b8a43d31bf95d7a0163..198176912361c0b9015914dd72ab9b075ca2cb9a 100644
--- a/media/gpu/video_decode_accelerator_unittest.cc
+++ b/media/gpu/video_decode_accelerator_unittest.cc
@@ -1493,16 +1493,17 @@ TEST_P(VideoDecodeAcceleratorParamTest, TestSimpleDecode) {
}
}
- std::unique_ptr<NotesVector> notes2(new NotesVector);
- notes2->swap(notes);
std::unique_ptr<ClientsVector> clients2(new ClientsVector);
clients2->swap(clients);
+ std::unique_ptr<NotesVector> notes2(new NotesVector);
+ notes2->swap(notes);
+ // |clients| must be deleted first because |clients| use |notes2|.
g_env->GetRenderingTaskRunner()->PostTask(
- FROM_HERE, base::Bind(&Delete<NotesVector>, base::Passed(&notes2)));
+ FROM_HERE, base::Bind(&Delete<ClientsVector>, base::Passed(&clients2)));
g_env->GetRenderingTaskRunner()->PostTask(
- FROM_HERE, base::Bind(&Delete<ClientsVector>, base::Passed(&clients2)));
+ FROM_HERE, base::Bind(&Delete<NotesVector>, base::Passed(&notes2)));
WaitUntilIdle();
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698